Skip to content

Conversation

@reta
Copy link
Contributor

@reta reta commented Apr 8, 2025

Description

Fix FileInterceptor to properly check read / write sides path separation

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Contributor Author

reta commented Apr 8, 2025

@andrross @kumargu @RajatGupta02 please take a look folks, thank you

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for a54bd73: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Andrew Ross <andrross@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 7953c74: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 7953c74: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

✅ Gradle check result for 7953c74: SUCCESS

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (c91cdcb) to head (7953c74).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...java/org/opensearch/javaagent/FileInterceptor.java 0.00% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17836      +/-   ##
============================================
- Coverage     72.46%   72.42%   -0.04%     
- Complexity    66502    66527      +25     
============================================
  Files          5408     5408              
  Lines        308080   308168      +88     
  Branches      44720    44744      +24     
============================================
- Hits         223239   223183      -56     
- Misses        66536    66798     +262     
+ Partials      18305    18187     -118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 6b976ea into opensearch-project:main Apr 8, 2025
30 of 32 checks passed
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ion (opensearch-project#17836)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
…ion (opensearch-project#17836)

Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andrew Ross <andrross@amazon.com>
Co-authored-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: Harsh Kothari <techarsh@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants