-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[rule based autotagging] Add Update Rule API Logic #17797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rule based autotagging] Add Update Rule API Logic #17797
Conversation
|
❌ Gradle check result for 9aa6685: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9aa6685 to
c83500d
Compare
|
❌ Gradle check result for c83500d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some high level comments. You can try to review these comments for other API PRs as well to avoid duplicated effort given there is lot of shared code here
...ing-commons/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Outdated
Show resolved
Hide resolved
...ing-commons/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Outdated
Show resolved
Hide resolved
...ing-commons/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Outdated
Show resolved
Hide resolved
...ing-commons/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Outdated
Show resolved
Hide resolved
libs/autotagging-commons/src/main/java/org/opensearch/rule/utils/IndexStoredRuleUtils.java
Outdated
Show resolved
Hide resolved
libs/autotagging-commons/src/main/java/org/opensearch/rule/action/UpdateRuleRequest.java
Outdated
Show resolved
Hide resolved
libs/autotagging-commons/src/main/java/org/opensearch/rule/action/UpdateRuleRequest.java
Show resolved
Hide resolved
libs/autotagging-commons/src/main/java/org/opensearch/rule/rest/RestUpdateRuleAction.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/autotagging/RuleValidator.java
Outdated
Show resolved
Hide resolved
libs/autotagging-commons/src/main/java/org/opensearch/rule/action/UpdateRuleRequest.java
Show resolved
Hide resolved
955eafe to
3de620c
Compare
|
❌ Gradle check result for 3de620c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...s/autotagging-commons/common/src/main/java/org/opensearch/rule/action/UpdateRuleRequest.java
Outdated
Show resolved
Hide resolved
|
@ruai0511 - Gradle failures are related to these code changes. Can you address those? Also comments have to be resolved, before PR can be merged |
3de620c to
13d7147
Compare
|
❌ Gradle check result for 13d7147: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
13d7147 to
e4a4e88
Compare
|
❌ Gradle check result for e4a4e88: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e4a4e88 to
84d43f0
Compare
|
❌ Gradle check result for 84d43f0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
84d43f0 to
4fea47c
Compare
|
flaky test failed. Retrying |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17797 +/- ##
==========================================
Coverage 72.66% 72.67%
- Complexity 67858 67974 +116
==========================================
Files 5521 5526 +5
Lines 312541 312676 +135
Branches 45364 45373 +9
==========================================
+ Hits 227113 227227 +114
- Misses 66903 66992 +89
+ Partials 18525 18457 -68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17797-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d0c2e39ae05454775b8063e09a88dd5f5834c49f
# Push it to GitHub
git push --set-upstream origin backport/backport-17797-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
…t#17797) --------- Signed-off-by: Lingxi Chen <lingxich@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>
…t#17797) --------- Signed-off-by: Lingxi Chen <lingxich@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
…t#17797) --------- Signed-off-by: Lingxi Chen <lingxich@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>
…t#17797) --------- Signed-off-by: Lingxi Chen <lingxich@amazon.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Lingxi Chen <lingxich@amazon.com>
Description
This PR introduces the update Rule API Logic.
An exampe API request is:
And the return would be
Rule Schema PR:
#17238
RFC:
#16797
Check List