-
Notifications
You must be signed in to change notification settings - Fork 2.3k
attempt to fix flaky test in IngestFromKinesisIT #17697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...-kinesis/src/internalClusterTest/java/org/opensearch/plugin/kinesis/IngestFromKinesisIT.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 17abbaf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b60c01b: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b60c01b: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for b60c01b: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17697 +/- ##
============================================
- Coverage 72.46% 72.41% -0.06%
- Complexity 65855 65862 +7
============================================
Files 5322 5322
Lines 305477 305477
Branches 44312 44312
============================================
- Hits 221359 221197 -162
- Misses 66023 66133 +110
- Partials 18095 18147 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
There's some flakiness of Kinesis integration tests, likely due to the fact that in LocalStack, the message propagation or availability might not be immediate. So when we immediately attempt to consume it, it might not be fully "visible" depending on timing, especially with a rewind to a precise AT_SEQUENCE_NUMBER. Tweaked the test with some more produced messages, and longer sleep so the records are committed and readable.
Ran the same tests 5 times locally, and test all passed.