Skip to content

Conversation

@ashking94
Copy link
Member

Description

This PR mutes the test class S3RemoteStoreIT as there is some flakiness observed in the tests. The test run time is high due to actual calls being made to S3. I am planning to fix the tests in a follow up PR and run the tests for 1000+ iterations. I have notice each iteration take around 10-15 mins with my setup. For now, this will mute the tests in S3RemoteStoreIT class.

Check List

  • [ ] Functionality includes testing.
  • [ ] API changes companion pull request created, if applicable.
  • [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for e6d9870: SUCCESS

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.51%. Comparing base (af5835f) to head (e6d9870).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17642      +/-   ##
============================================
+ Coverage     72.44%   72.51%   +0.07%     
- Complexity    65732    65771      +39     
============================================
  Files          5311     5311              
  Lines        305011   305011              
  Branches      44232    44232              
============================================
+ Hits         220969   221189     +220     
+ Misses        65967    65716     -251     
- Partials      18075    18106      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashking94 ashking94 merged commit ebd743a into opensearch-project:main Mar 20, 2025
57 of 58 checks passed
@ashking94 ashking94 added the backport 2.x Backport to 2.x branch label Mar 20, 2025
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-17642-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ebd743a50cd7162f1552568c367b60dea077774e
# Push it to GitHub
git push --set-upstream origin backport/backport-17642-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-17642-to-2.x.

@ashking94 ashking94 removed backport 2.x Backport to 2.x branch backport-failed labels Mar 21, 2025
bzhangam pushed a commit to bzhangam/OpenSearch that referenced this pull request Mar 25, 2025
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants