Skip to content

Conversation

@expani
Copy link
Contributor

@expani expani commented Mar 17, 2025

Related Issues

Resolves (#17585)

Signed-off-by: expani <anijainc@amazon.com>
@expani
Copy link
Contributor Author

expani commented Mar 17, 2025

Still wrapping my head around the changes required for @mch2 comment on minimum_wire_compatibility_version

Might include it here later.

cc: @peterzhuamazon @andrross

@github-actions
Copy link
Contributor

✅ Gradle check result for 637fc25: SUCCESS

@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.54%. Comparing base (e27cf58) to head (637fc25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #17605   +/-   ##
=========================================
  Coverage     72.53%   72.54%           
+ Complexity    65814    65747   -67     
=========================================
  Files          5311     5311           
  Lines        304945   304944    -1     
  Branches      44226    44226           
=========================================
+ Hits         221193   221219   +26     
+ Misses        65619    65599   -20     
+ Partials      18133    18126    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross
Copy link
Member

andrross commented Mar 17, 2025

Still wrapping my head around the changes required for @mch2 comment on minimum_wire_compatibility_version

@expani I believe this is sufficient. Running the server with this commit produces this output:

$ curl localhost:9200
{
  "name" : "runTask-0",
  "cluster_name" : "runTask",
  "cluster_uuid" : "iQSI0XjdRryROsQPd8CDsg",
  "version" : {
    "distribution" : "opensearch",
    "number" : "3.0.0-SNAPSHOT",
    "build_type" : "tar",
    "build_hash" : "637fc25408e167cf78ad523ad87fb55e0b6fdf02",
    "build_date" : "2025-03-17T15:14:19.331696Z",
    "build_snapshot" : true,
    "lucene_version" : "10.1.0",
    "minimum_wire_compatibility_version" : "2.19.0",
    "minimum_index_compatibility_version" : "2.0.0"
  },
  "tagline" : "The OpenSearch Project: https://opensearch.org/"
}

And if you dig through the full gradle check output you can see it is running the tests against 2.19.2.

/cc @mch2

@andrross andrross merged commit 6c0a95b into opensearch-project:main Mar 17, 2025
58 of 59 checks passed
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Mar 18, 2025
Signed-off-by: expani <anijainc@amazon.com>
Signed-off-by: Vinay Krishna Pudyodu <vinkrish.neo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants