fix simultaneously creating a snapshot and updating the repository can potentially trigger an infinite loop #17532
Conversation
kkewwei
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
kkewwei
force-pushed
the
fix_loop_in_updateRep
branch
from
3185a72 to
2a17f65
Compare
|
❌ Gradle check result for 2a17f65: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
kkewwei
force-pushed
the
fix_loop_in_updateRep
branch
from
2a17f65 to
0a9da2d
Compare
github-project-automation
bot
moved this from ✅ Done
to 🏗 In progress
in Storage Project Board
|
❌ Gradle check result for 6ebee6d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
MinimumClusterManagerNodesIT.testThreeNodesNoClusterManagerBlock #14289 |
|
@andrross @ashking94 I'm very sorry to mention you again. Could someone help continue to review or merge the PR? There are too many flaky tests and Gradle check always fails. Your help is greatly appreciated. I want to continue #17488, but was blocked by this PR. |
Thanks for sticking with this @kkewwei. A lot of us are busy with the 3.0 release and as you've noted flaky tests are a major problem at the moment. |
|
❌ Gradle check result for 6ebee6d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
github-project-automation
bot
moved this from 🏗 In progress
to 👀 In review
in Storage Project Board
|
❌ Gradle check result for 6ebee6d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6ebee6d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
andrross
force-pushed
the
fix_loop_in_updateRep
branch
from
6ebee6d to
7415b92
Compare
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Storage Project Board
…ject#17532) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Tanishq Ranjan <tqranjan@amazon.com>
…ject#17532) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
…ject#17532) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: Harsh Kothari <techarsh@amazon.com>
4 participants
Description
Related Issues
Resolves #17531
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.