Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] various builder and mapping deprecations #1752

Merged
merged 1 commit into from
Dec 17, 2021
Merged

[Remove] various builder and mapping deprecations #1752

merged 1 commit into from
Dec 17, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Dec 16, 2021 •
edited
Loading

This PR removes the following deprecations and invalid tests:

  • LegacyUpdateMappingIntegrationIT
  • ShapeBuilder new z axis checks
  • MatchPhrase new zeroTermsQuery checks
  • TypeQuery utf8
  • CompositeValuesSource format checks
  • LegacyESVersionTests bumped to 6.8.15
  • LegacyDynamicMapping, LegacySimilarity, LegacyMapperService tests (no longer supported)

@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues labels Dec 16, 2021
@nknize nknize requested a review from a team as a code owner December 16, 2021 22:50
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d4e67c7ff293083491614caee755decd7377cdfc
Log 1549

Reports 1549

@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

Digging... this is a legit failure but unrelated to this PR!!! Looks like a possible rounding error. Will open an issue and address in a separate PR.

./gradlew ':server:test' --tests "org.opensearch.search.aggregations.metrics.TDigestStateTests.testMoreThan4BValues" -Dtests.seed=5630AE9543646685 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m -Djava.security.manager=allow" -Dtests.locale=el-GR -Dtests.timezone=Indian/Chagos -Druntime.java=17

  2> java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([5630AE9543646685:54203DC5B4948AA7]:0)
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at org.opensearch.search.aggregations.metrics.TDigestStateTests.testMoreThan4BValues(TDigestStateTests.java:60)
  2> NOTE: leaving temporary files on disk at: /opt/dev/opensearch-project/opensearch/server/build/testrun/test/temp/org.opensearch.search.aggregations.metrics.TDigestStateTests_5630AE9543646685-001
  2> NOTE: test params are: codec=Asserting(Lucene87): {}, docValues:{}, maxPointsInLeafNode=1147, maxMBSortInHeap=5.679778913474905, sim=Asserting(RandomSimilarity(queryNorm=false): {}), locale=el-GR, timezone=Indian/Chagos
  2> NOTE: Linux 4.15.0-163-generic amd64/Oracle Corporation 17.0.1 (64-bit)/cpus=8,threads=1,free=522861872,total=536870912
  2> NOTE: All tests run in this JVM: [TDigestStateTests]

assertTrue(v >= prev); fails w/ following values:
v=3.1138788538165313E-4
prev=3.113878853816532E-4

@nknize nknize mentioned this pull request Dec 16, 2021
Closed
@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

opened #1756

@nknize
Copy link
Collaborator Author

nknize commented Dec 16, 2021

start gradle check

@nknize nknize force-pushed the remove/builderAndMapping6xDeprecations branch from d4e67c7 to 10c41f4 Compare December 16, 2021 23:43
@nknize
[Remove] various builder and mapping deprecations
6b10e0d 
This commit removes the following deprecations and invalid tests:

* LegacyUpdateMappingIntegrationIT
* ShapeBuilder new z axis checks
* MatchPhrase new zeroTermsQuery checks
* TypeQuery utf8
* CompositeValuesSource format checks
* LegacyESVersionTests bumped to 6.8.15
* LegacyDynamicMapping, LegacySimilarity, LegacyMapperService tests

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the remove/builderAndMapping6xDeprecations branch from 10c41f4 to 6b10e0d Compare December 16, 2021 23:44
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 10c41f49cc76050be1484cf9d597ce22ff67c15f
Log 1552

Reports 1552

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6b10e0d
Log 1554

Reports 1554

adnapibar
adnapibar approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nknize nknize merged commit 6cc462b into opensearch-project:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adnapibar adnapibar adnapibar approved these changes

Assignees
No one assigned
Labels
non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nknize @opensearch-ci-bot @adnapibar