-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[rule based autotagging] Add Get Rule API Logic #17336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rule based autotagging] Add Get Rule API Logic #17336
Conversation
d825a21 to
db57bcb
Compare
|
❌ Gradle check result for db57bcb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
db57bcb to
f7bea2e
Compare
|
❌ Gradle check result for f7bea2e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f7bea2e to
4d2d843
Compare
|
❌ Gradle check result for 4d2d843: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 218c090: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
218c090 to
52c1954
Compare
|
❌ Gradle check result for 52c1954: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
de5a136 to
50f3d11
Compare
|
❌ Gradle check result for 50f3d11: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
50f3d11 to
9087c7f
Compare
|
❌ Gradle check result for 9087c7f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Unrelated failures, retrying gradle check: |
|
❌ Gradle check result for 9087c7f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
9b215e1 to
14237d2
Compare
14237d2 to
f1f2108
Compare
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
f1f2108 to
d6b3e79
Compare
* add get rule api logic Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * rebase from main after the schema merged Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * extract common logics to libs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * Add javadocs for libs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * correct UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> r * refactor code and fix ut Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * remove commented code Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * address comments Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * change method name Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix merge conflicts Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rename queryGroup to workloadGroup Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add guice binding related changes Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * refactor code to create a generic rule framework structure Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix javadoc Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * fix UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * restructure tests Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * rebase with mainline Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * fix gradlew file Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add action UTs Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * correct the comment Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> * add more UT Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> --------- Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com> Co-authored-by: Kaushal Kumar <ravi.kaushal97@gmail.com> (cherry picked from commit 8932876) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR introduces the get Rule API Logic.
An example API request is:
And the return would be
Rule Schema PR:
#17238
RFC:
#16797
Check List