-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemd integ tests to run with docker #17308
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
❌ Gradle check result for e9c7531: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
qa/systemd-test/docker-compose.yml
Outdated
container_name: opensearch-systemd-test-container | ||
build: | ||
dockerfile_inline: | | ||
FROM amazonlinux:2023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we use cloud vendor neutral image here? We have a large number of distributions here under qa\os
folder (many are outdated sadly, may be a good opportunity to fix that)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, does this image quay.io/centos/centos:stream9
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Docker images we use are stuck with centos:8
: https://github.com/opensearch-project/OpenSearch/blob/main/buildSrc/src/main/java/org/opensearch/gradle/DockerBase.java#L39
Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
❌ Gradle check result for 56c519d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
This PR adds integration tests for the systemd unit file that ships with the opensearch distribution. The tests run on the systemd service that runs within a docker container. The tests have been written to run with the systemd unit file that is expected to release with version 3.0 .
Supporting References
Related PR: #17107
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.