-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating .gitattributes for additional file types #1727
Conversation
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Can one of the admins verify this patch? |
@reta can you help verify this on a Windows machine? |
@@ -1,8 +1,12 @@ | |||
* text eol=lf | |||
*.bat text eol=crlf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm ... why changing that? *.bat
are 100% Windows specific, where crlf
rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some how linux is unhappy with modified: gradlew.bat
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably need to find out why, Windows users might not like it since not all editors on Windows support Linux style, mind if I take a look tomorrow? Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely, I'll hold this PR and I'll take a look as well. Thanks @reta !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saratvemulapalli totally forgot about this one, sorry, looking ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, nonetheless it looks a bit weird, the binary does not hurt, let's try it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah lets give it a shot, feels like all platforms are happy. We can always change it.
Thanks @reta !
Looks fine, thanks @saratvemulapalli
|
Description
Updating
.gitattributes
for additional file types.With exiting
.gitattributes
, Linux is seeing unexpected changes:Tested on Linux, and MacOS.
Issues Resolved
#1713
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.