Skip to content

[Backport 2.x] Show only intersecting buckets to the Adjacency matrix aggregation #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 15, 2025
Merged

[Backport 2.x] Show only intersecting buckets to the Adjacency matrix aggregation #17006

merged 2 commits into from
Jan 15, 2025

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 8d5e1a3 from #11733.

@github-actions
Show only intersecting buckets to the Adjacency matrix aggregation (#…
0972354 
…11733)

Signed-off-by: Ivan Brusic <ivan@brusic.com>
(cherry picked from commit 8d5e1a3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 0972354: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@msfroh
Update version checks for backport
fa3c9d3 
Signed-off-by: Michael Froh <froh@amazon.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for fa3c9d3: SUCCESS

@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.57576% with 14 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (de832d7) to head (fa3c9d3).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
...t/adjacency/AdjacencyMatrixAggregationBuilder.java 69.23% 3 Missing and 5 partials ⚠️
...ns/bucket/adjacency/AdjacencyMatrixAggregator.java 0.00% 5 Missing ⚠️
...et/adjacency/AdjacencyMatrixAggregatorFactory.java 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #17006      +/-   ##
============================================
+ Coverage     71.79%   71.94%   +0.14%     
- Complexity    65501    65631     +130     
============================================
  Files          5318     5318              
  Lines        305777   305801      +24     
  Branches      44581    44586       +5     
============================================
+ Hits         219540   220012     +472     
+ Misses        67895    67416     -479     
- Partials      18342    18373      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added the v2.19.0 Issues and PRs related to version 2.19.0 label Jan 15, 2025
@reta reta merged commit bf06726 into 2.x Jan 15, 2025
41 of 44 checks passed
@github-actions github-actions bot deleted the backport/backport-11733-to-2.x branch January 15, 2025 15:27
@reta reta mentioned this pull request Jan 15, 2025
Merged
This was referenced Jan 15, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees

No one assigned

Labels

skip-changelog v2.19.0 Issues and PRs related to version 2.19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reta @msfroh