-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Arrow Flight Server bootstrap logic #16962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arrow Flight Server bootstrap logic #16962
Conversation
|
❌ Gradle check result for 53ad56f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
53ad56f to
f360c80
Compare
|
❌ Gradle check result for f360c80: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
83b63d3 to
b38f302
Compare
|
❌ Gradle check result for b38f302: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@rishabhmaurya I know that this is work in progress but please take a look at [1] where the notion of auxiliary transports (and plugins implementing ones, like gRPC), has been introduced. We may (and very likely - should) consider Apache Arrow Flight as one of such transports, it should be optional plugin and not part of the core server. Thank you [1] #16534 |
|
@reta thanks for the pointer, I will update the PR and try to use aux transport. |
4cae87e to
60f82e9
Compare
|
❌ Gradle check result for 60f82e9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
60f82e9 to
f9623e9
Compare
|
❌ Gradle check result for f9623e9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4601334 to
93df0aa
Compare
|
❌ Gradle check result for 93df0aa: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
93df0aa to
63bc0f4
Compare
|
❌ Gradle check result for 63bc0f4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
63bc0f4 to
d364c1c
Compare
|
❌ Gradle check result for d364c1c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@reta do you know how can i address the gradle check failure related to |
@rishabhmaurya It is caused by https://github.com/opensearch-project/OpenSearch/pull/16962/files#diff-756d8dcb1dfd9f8fa9bf974880af0b001cef12541eb17857ff30d4aa922bc05eR200 (change in server/src/main/resources/org/opensearch/bootstrap/security.policy |
|
@reta ah, thanks. How did you find that out as I couldn't find any error message in the logs |
@rishabhmaurya needed some debugging, afair some tests were required some more security permissions but those could be ignored (since tests are focused on diagnostics) |
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…ded libs (not needed at the moment) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…arch is just for overriding purpose Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Signed-off-by: Andriy Redko <drreta@gmail.com>
Co-authored-by: Andriy Redko <drreta@gmail.com> Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
…feature flag Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
Signed-off-by: Rishabh Maurya <rishabhmaurya05@gmail.com>
a78910f to
ddd47fa
Compare
Description
This PR adds server bootstrap logic for Arrow Flight. This is in continuation to #16691
StreamManagerimplementation behind feature flag with default behaviour as disabled.SslContextin Flight server and client.SecureTransportSettingsProviderto buildSslContextoutside of security plugin.ClientManagerfor creating a pool of flight clients for data nodes only.ServerConfig.arrow-memory-shadedandflight-core-shadedto share dependencies to avoid polluting server classpath.moved to next PR (Base Flight producer integration with Flight Server #17066)StreamManagerwrapper for integration with task API.integration ofmoved to next PR (Base Flight producer integration with Flight Server #17066)StreamManagerwith server module.TODOs:
SslContextusingSecureTransportSettingsProvider[FEATURE] Support additional params in SecureTransportSettingsProvider to enable building of SslContext outside of security plugin security#5011ServerConfig- [Feature Request] Tune up server config for Flight server #16966I will handle both of them as part of follow up PRs.
Related Issues
Resolves #16963
#16679
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.