Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] ElasticsearchParseException class in server module #169

Merged
merged 5 commits into from
Mar 4, 2021
Merged

[Rename] ElasticsearchParseException class in server module #169

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d46cc2f
[Rename] ElasticsearchParseException class in server module
nknize Mar 3, 2021
20574df
Merge branch 'rename/opensearch' into rename/server/ElasticsearchPars…
nknize Mar 4, 2021
6691aee
[Rename] add back fqpn
nknize Mar 4, 2021
3af19a9
Merge branch 'rename/opensearch' into rename/server/ElasticsearchPars…
nknize Mar 4, 2021
0a0caac
[Rename] Variable rename
nknize Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Rename] add back fqpn 
Signed-off-by: Nicholas Knize <nknize@amazon.com>
  • Loading branch information
@nknize
nknize committed Mar 4, 2021
commit 6691aeea6ef91e1eec32150f0abe8932c88ecea4
4 changes: 2 additions & 2 deletions server/src/main/java/org/elasticsearch/OpenSearchException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,8 +799,8 @@ private enum OpenSearchExceptionHandle {
org.elasticsearch.indices.IndexPrimaryShardNotAllocatedException::new, 33, UNKNOWN_VERSION_ADDED),
TRANSPORT_EXCEPTION(org.elasticsearch.transport.TransportException.class,
org.elasticsearch.transport.TransportException::new, 34, UNKNOWN_VERSION_ADDED),
ELASTICSEARCH_PARSE_EXCEPTION(OpenSearchParseException.class,
OpenSearchParseException::new, 35, UNKNOWN_VERSION_ADDED),
ELASTICSEARCH_PARSE_EXCEPTION(org.elasticsearch.OpenSearchParseException.class,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we renaming the enums as part of a separate PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think at this point making a separate sweeping rename PR is the right move

org.elasticsearch.OpenSearchParseException::new, 35, UNKNOWN_VERSION_ADDED),
SEARCH_EXCEPTION(org.elasticsearch.search.SearchException.class,
org.elasticsearch.search.SearchException::new, 36, UNKNOWN_VERSION_ADDED),
MAPPER_EXCEPTION(org.elasticsearch.index.mapper.MapperException.class,
Expand Down