Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cluster setting to allow caching requests with size>0 in request cache #16484

Merged
merged 10 commits into from
Nov 1, 2024
+101 −16
Merged

Adds cluster setting to allow caching requests with size>0 in request cache #16484

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
29a23c0
Add cluster setting to allow size>0 in request cache
Oct 25, 2024
ccfb3e4
Add to changelog
Oct 25, 2024
86ec73e
addressed dbwiddis's comments
Oct 28, 2024
3258000
make canCacheSizeNonzeroRequests volatile
Oct 28, 2024
2c4a1a8
Merge branch 'main' into caching-setting
peteralfonsi Oct 28, 2024
f54a0cf
fix changelog merge
Oct 28, 2024
1d955ef
Changed setting name
Oct 28, 2024
fe3818a
more renaming
Oct 28, 2024
c37b2bb
fix spotless check
Oct 28, 2024
99cbb04
rerun gradle check
Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make canCacheSizeNonzeroRequests volatile 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
  • Loading branch information
Peter Alfonsi committed Oct 28, 2024
commit 3258000b79092cc669f1a335197e8d359368f21f
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/indices/IndicesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ public class IndicesService extends AbstractLifecycleComponent
private final FileCache fileCache;
private final CompositeIndexSettings compositeIndexSettings;
private final Consumer<IndexShard> replicator;
private boolean canCacheSizeNonzeroRequests;
private volatile boolean canCacheSizeNonzeroRequests;

@Override
protected void doStart() {
Expand Down
Loading