Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Change default retry mechanism of s3 client to Standard Mode (#15978) #16168

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

Arpit-Bandejiya
Copy link
Contributor

@Arpit-Bandejiya Arpit-Bandejiya commented Oct 2, 2024

The automated backport failed due to conflicts in the ChangeLog.md raised the PR after fixing the conflict.
Signed-off-by: Arpit Bandejiya abandeji@amazon.com

(cherry picked from commit 908fefe)

Description

Backport #15978

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rch-project#15978)

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>

(cherry picked from commit 908fefe)
Copy link
Contributor

github-actions bot commented Oct 2, 2024

❕ Gradle check result for 0c262c8: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (20d32cf) to head (0c262c8).
Report is 9 commits behind head on 2.x.

Files with missing lines Patch % Lines
...org/opensearch/repositories/s3/S3AsyncService.java 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16168      +/-   ##
============================================
+ Coverage     71.60%   71.66%   +0.05%     
- Complexity    64716    64762      +46     
============================================
  Files          5278     5278              
  Lines        302835   302876      +41     
  Branches      44059    44059              
============================================
+ Hits         216848   217057     +209     
+ Misses        67932    67714     -218     
- Partials      18055    18105      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashking94 ashking94 merged commit d4ebfab into opensearch-project:2.x Oct 2, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.18.0 Issues and PRs related to version 2.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants