Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow RemotePublication configured nodes to join remote cluster in mixed mode #15994

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Allow RemotePublication configured nodes to join remote cluster in mixed mode #15994

merged 1 commit into from
Sep 26, 2024

Conversation

rajiv-kv
Copy link
Contributor

@rajiv-kv rajiv-kv commented Sep 19, 2024 •
edited by gbbafna
Loading

Description

Currently in MIXED compatibility mode, a non-remote node of same version can join the Remote cluster. On similar lines, this fix allows node with RemotePublication repositories configured to join Remote cluster in MIXED mode.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 844b9d5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for c3c4627: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for aaa0719: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 78306e7: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testStartReplicationListenerSuccess

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (b3cc802) to head (c70e251).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #15994      +/-   ##
============================================
- Coverage     72.01%   71.86%   -0.16%     
+ Complexity    64425    64351      -74     
============================================
  Files          5281     5281              
  Lines        301004   301026      +22     
  Branches      43482    43485       +3     
============================================
- Hits         216779   216323     -456     
- Misses        66423    66991     +568     
+ Partials      17802    17712      -90

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajiv-kv rajiv-kv changed the title allow RemotePublication configured nodes to join remote cluster in mi… Allow RemotePublication configured nodes to join remote cluster in mixed mode Sep 19, 2024
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 18, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 813322a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ba4a52a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5e8295c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 23, 2024
Closed
@rajiv-kv rajiv-kv marked this pull request as ready for review September 24, 2024 12:03
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 5eb883f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv rajiv-kv force-pushed the publish-node-join-remote branch 2 times, most recently from 1965ae3 to b61661f Compare September 24, 2024 16:45
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b61661f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 6d2a877: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rajiv-kv
allow RemotePublication configured nodes to join remote cluster in mi…
c70e251 
…xed mode

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for c70e251: SUCCESS

@gbbafna gbbafna merged commit 5888867 into opensearch-project:main Sep 26, 2024
38 of 40 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Sep 26, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 26, 2024
@github-actions
Allow RemotePublication configured nodes to join remote cluster in mi…
4f628be 
…xed mode (#15994)

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
(cherry picked from commit 5888867)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 26, 2024
Merged
gbbafna pushed a commit that referenced this pull request Sep 27, 2024
@opensearch-trigger-bot @github-actions
Allow RemotePublication configured nodes to join remote cluster in mi…
6375b62 
…xed mode (#15994) (#16090)

(cherry picked from commit 5888867)

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request Oct 4, 2024
@rajiv-kv @ruai0511
Allow RemotePublication configured nodes to join remote cluster in mi…
a41445b 
…xed mode (opensearch-project#15994)

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
@rajiv-kv @dk2k
Allow RemotePublication configured nodes to join remote cluster in mi…
c8f4ce5 
…xed mode (opensearch-project#15994)

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
@rajiv-kv @dk2k
Allow RemotePublication configured nodes to join remote cluster in mi…
b06dd95 
…xed mode (opensearch-project#15994)

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
@rajiv-kv @dk2k
Allow RemotePublication configured nodes to join remote cluster in mi…
6338e9d 
…xed mode (opensearch-project#15994)

Signed-off-by: Rajiv Kumar Vaidyanathan <rajivkv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rajiv-kv @gbbafna