Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests fix in 2.x branch #15805

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

sachinpkale
Copy link
Member

@sachinpkale sachinpkale commented Sep 6, 2024

Description

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

mch2 and others added 2 commits September 6, 2024 18:25
…onsUpload (opensearch-project#15732)

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for d524515: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

ltaragi and others added 2 commits September 6, 2024 18:47
Signed-off-by: Lakshya Taragi <lakshya.taragi@gmail.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Lakshya Taragi <157457166+ltaragi@users.noreply.github.com>
…15462)

---------

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Sachin Kale <kalsac@amazon.com>
Co-authored-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Gradle check result for 8fc0d8a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…ject#15644)

Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Sachin Kale <kalsac@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❕ Gradle check result for 1c12a6f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

✅ Gradle check result for e0fee9c: SUCCESS

@sachinpkale sachinpkale merged commit a24c858 into opensearch-project:2.x Sep 6, 2024
34 checks passed
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 30.97826% with 127 lines in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (dcdc4d2) to head (e0fee9c).
Report is 13 commits behind head on 2.x.

Files with missing lines Patch % Lines
...java/org/opensearch/index/shard/StoreRecovery.java 0.00% 61 Missing ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 26.47% 20 Missing and 5 partials ⚠️
...ch/repositories/blobstore/BlobStoreRepository.java 22.22% 11 Missing and 3 partials ⚠️
...org/opensearch/cluster/routing/RecoverySource.java 52.38% 6 Missing and 4 partials ⚠️
...ster/snapshots/restore/RestoreSnapshotRequest.java 33.33% 3 Missing and 5 partials ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java 25.00% 1 Missing and 2 partials ⚠️
.../org/opensearch/index/translog/TranslogConfig.java 50.00% 2 Missing ⚠️
...search/snapshots/InternalSnapshotsInfoService.java 84.61% 1 Missing and 1 partial ⚠️
...n/java/org/opensearch/repositories/Repository.java 0.00% 1 Missing ⚠️
...ava/org/opensearch/snapshots/SnapshotsService.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15805      +/-   ##
============================================
+ Coverage     71.55%   71.57%   +0.01%     
- Complexity    64312    64372      +60     
============================================
  Files          5262     5263       +1     
  Lines        301279   301528     +249     
  Branches      43861    43903      +42     
============================================
+ Hits         215574   215808     +234     
+ Misses        67703    67701       -2     
- Partials      18002    18019      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants