-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version check for fix the bug of missing validation for the search_backpressure.mode setting #15500
Conversation
…arch_backpressure.mode setting Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Thanks a lot @gaobinlong ! |
❌ Gradle check result for eb4ba1e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15500 +/- ##
============================================
- Coverage 71.90% 71.83% -0.08%
+ Complexity 63481 63399 -82
============================================
Files 5244 5244
Lines 296798 296798
Branches 42852 42852
============================================
- Hits 213414 213202 -212
- Misses 65917 66092 +175
- Partials 17467 17504 +37 ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15500-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e5fadba7b82da4da714cac37aa335a3be230eace
# Push it to GitHub
git push --set-upstream origin backport/backport-15500-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@gaobinlong mind please backport manually (if needed), thank you |
Actually it's not needed because the version check has been changed in 2.x branch, but doesn't match the version in this PR, I'll make them consistent in another PR. |
…arch_backpressure.mode setting (opensearch-project#15500) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…arch_backpressure.mode setting (opensearch-project#15500) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…arch_backpressure.mode setting (opensearch-project#15500) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
…arch_backpressure.mode setting (opensearch-project#15500) Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Description
This PR fixed the bug of the validation for the cluster level
search_backpressure.mode
setting is missing, we need to update the version check in the yaml test file.Changelog is not needed, backport 2.x is needed.
Related Issues
No issue.
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.