Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Netty's ByteBuf leak #15475

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

reta
Copy link
Collaborator

@reta reta commented Aug 28, 2024

Description

Fix Netty's ByteBuf leak

java.lang.AssertionError: 
Expected: an empty collection
     but: <[LEAK: ByteBuf.release() was not called before it's garbage-collected. See https://netty.io/wiki/reference-counted-objects.html for more information.
Recent access records: 
#1:
	org.opensearch.http.reactor.netty4.ReactorNetty4StreamingRequestConsumer.createChunk(ReactorNetty4StreamingRequestConsumer.java:47)
	org.opensearch.http.reactor.netty4.ReactorNetty4StreamingRequestConsumer.accept(ReactorNetty4StreamingRequestConsumer.java:37)
	org.opensearch.http.reactor.netty4.ReactorNetty4StreamingRequestConsumer.accept(ReactorNetty4StreamingRequestConsumer.java:23)

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Copy link
Collaborator Author

reta commented Aug 28, 2024

@andrross please when you have time, thanks (and apologies for that)

@reta reta added the backport 2.x Backport to 2.x branch label Aug 28, 2024
Copy link
Contributor

❌ Gradle check result for 0e0df64: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 0e0df64: SUCCESS

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

✅ Gradle check result for 4555934: SUCCESS

Copy link
Contributor

✅ Gradle check result for 77dcf7c: SUCCESS

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (b30df02) to head (77dcf7c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ch/http/reactor/netty4/ReactorNetty4HttpChunk.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15475      +/-   ##
============================================
+ Coverage     71.92%   71.93%   +0.01%     
- Complexity    63328    63370      +42     
============================================
  Files          5227     5227              
  Lines        296497   296492       -5     
  Branches      42830    42830              
============================================
+ Hits         213248   213279      +31     
+ Misses        65764    65744      -20     
+ Partials      17485    17469      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator Author

reta commented Aug 28, 2024

@andrross may I ask please to reapprove? thank you!

@andrross andrross merged commit acee2ae into opensearch-project:main Aug 28, 2024
34 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit acee2ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jainankitk added a commit that referenced this pull request Aug 29, 2024
(cherry picked from commit acee2ae)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ankit Jain <akjain@amazon.com>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants