[repository-azure] Update to the latest Azure Storage SDK v12, remove privileged runnable wrapper in favor of access helper #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… privileged runnable wrapper in favor of access helper Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
commented
Nov 9, 2021
| }); | ||
| }; | ||
| final Thread t = new Thread(group, priviledged, namePrefix + threadNumber.getAndIncrement(), 0); | ||
| final Thread t = new Thread(group, r, namePrefix + threadNumber.getAndIncrement(), 0); |
There was a problem hiding this comment.
No need to wrap anymore :-)
|
Can one of the admins verify this patch? |
|
✅ Gradle Wrapper Validation success ea9456b |
|
✅ Gradle Precommit success ea9456b |
saratvemulapalli
approved these changes
Nov 10, 2021
| }); | ||
| }; | ||
| final Thread t = new Thread(group, priviledged, namePrefix + threadNumber.getAndIncrement(), 0); | ||
| final Thread t = new Thread(group, r, namePrefix + threadNumber.getAndIncrement(), 0); |
saratvemulapalli
added
Plugins
pending backport
|
@reta could you also backport this PR to 1.x? |
|
@saratvemulapalli definitely, on it |
reta
added a commit
to reta/OpenSearch
that referenced
this pull request
Nov 11, 2021
… privileged runnable wrapper in favor of access helper (opensearch-project#1521) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
5 tasks
saratvemulapalli
removed
the
pending backport
iclonghoang
pushed a commit
to instaclustr/OpenSearch
that referenced
this pull request
Dec 21, 2021
… privileged runnable wrapper in favor of access helper (opensearch-project#1521) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
The fix for [1] has finally arrived to latest Azure Storage SDK releases. We could get rid of privileged runnable wrapper and use access helper (for
JacksonAdapterserialization / deserialization). More details in [2], [3][1] Azure/azure-sdk-for-java#24373
[2] Azure/azure-sdk-for-java#25004
[3] Azure/azure-sdk-for-java#24374
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.