Do not build shard level ranges if query is not effective match all f…

…or range agg filter rewrite optimization

Signed-off-by: Finn Carroll <carrofin@amazon.com>

server/src/main/java/org/opensearch/search/aggregations/bucket/filterrewrite/Helper.java

@@ -60,7 +60,7 @@ private Helper() {}
      * Recursively unwraps query into the concrete form
      * for applying the optimization
      */
-    private static Query unwrapIntoConcreteQuery(Query query) {
+    public static Query unwrapIntoConcreteQuery(Query query) {
         while (queryWrappers.containsKey(query.getClass())) {
             query = queryWrappers.get(query.getClass()).apply(query);
         }

server/src/main/java/org/opensearch/search/aggregations/bucket/filterrewrite/RangeAggregatorBridge.java

@@ -10,11 +10,14 @@
 
 import org.apache.lucene.index.LeafReaderContext;
 import org.apache.lucene.index.PointValues;
+import org.apache.lucene.search.MatchAllDocsQuery;
+import org.apache.lucene.search.Query;
 import org.opensearch.index.mapper.MappedFieldType;
 import org.opensearch.index.mapper.NumericPointEncoder;
 import org.opensearch.search.aggregations.bucket.range.RangeAggregator;
 import org.opensearch.search.aggregations.support.ValuesSource;
 import org.opensearch.search.aggregations.support.ValuesSourceConfig;
+import org.opensearch.search.internal.SearchContext;
 
 import java.io.IOException;
 import java.util.function.BiConsumer;
@@ -51,8 +54,14 @@ protected boolean canOptimize(ValuesSourceConfig config, RangeAggregator.Range[]
         return false;
     }
 
-    protected void buildRanges(RangeAggregator.Range[] ranges) {
+    protected void buildRanges(RangeAggregator.Range[] ranges, SearchContext context) {
         assert fieldType instanceof NumericPointEncoder;
+        Query unwrap = Helper.unwrapIntoConcreteQuery(context.query());
+        if (!(unwrap instanceof MatchAllDocsQuery)) {
+            setRanges.accept(null);
+            return;
+        }
+
         NumericPointEncoder numericPointEncoder = (NumericPointEncoder) fieldType;
         byte[][] lowers = new byte[ranges.length][];
         byte[][] uppers = new byte[ranges.length][];

server/src/main/java/org/opensearch/search/aggregations/bucket/range/RangeAggregator.java

@@ -289,7 +289,7 @@ protected boolean canOptimize() {
 
             @Override
             protected void prepare() {
-                buildRanges(ranges);
+                buildRanges(ranges, context);
             }
 
             @Override