Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing pagination for _cat/indices API #14718

Merged
merged 16 commits into from
Sep 30, 2024

Retry Build

c8261d4
Select commit
Loading
Failed to load commit list.
Merged

Implementing pagination for _cat/indices API #14718

Retry Build
c8261d4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 29, 2024 in 0s

71.82% (target 70.00%)

View this Pull Request on Codecov

71.82% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 67.61905% with 68 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (d510b12) to head (c8261d4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../opensearch/rest/action/cat/RestIndicesAction.java 38.88% 22 Missing ⚠️
...pensearch/rest/action/list/AbstractListAction.java 6.25% 15 Missing ⚠️
...earch/rest/pagination/IndexPaginationStrategy.java 82.60% 7 Missing and 5 partials ⚠️
...search/rest/action/list/RestIndicesListAction.java 56.52% 9 Missing and 1 partial ⚠️
...opensearch/rest/pagination/PaginationStrategy.java 55.55% 2 Missing and 2 partials ⚠️
...src/main/java/org/opensearch/rest/RestHandler.java 0.00% 1 Missing ⚠️
...src/main/java/org/opensearch/rest/RestRequest.java 0.00% 1 Missing ⚠️
...java/org/opensearch/rest/action/cat/RestTable.java 94.11% 0 Missing and 1 partial ⚠️
...rg/opensearch/rest/action/list/RestListAction.java 90.90% 1 Missing ⚠️
...java/org/opensearch/rest/pagination/PageToken.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14718      +/-   ##
============================================
- Coverage     71.91%   71.82%   -0.10%     
+ Complexity    64420    64361      -59     
============================================
  Files          5281     5288       +7     
  Lines        301228   301419     +191     
  Branches      43519    43549      +30     
============================================
- Hits         216643   216498     -145     
- Misses        66835    67129     +294     
- Partials      17750    17792      +42

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov