Skip to content

[Backport 2.x] Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings #14705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: [Backport 2.x] [Rule based auto tagging] Add in-memory rule processing service
merged 1 commit into from
Jul 10, 2024
Merged

[Backport 2.x] Add unit tests for read flow of RemoteClusterStateService and bug fix for transient settings #14705

merged 1 commit into from
Jul 10, 2024

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport b068355 from #14476.

@github-actions
Add unit tests for read flow of RemoteClusterStateService and bug fix…
f156a1c 
… for transient settings (#14476)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
(cherry picked from commit b068355)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

✅ Gradle check result for f156a1c: SUCCESS

@codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.47%. Comparing base (7040df2) to head (f156a1c).
Report is 11 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14705      +/-   ##
============================================
+ Coverage     71.42%   71.47%   +0.04%     
- Complexity    62382    62415      +33     
============================================
  Files          5103     5106       +3     
  Lines        293268   293472     +204     
  Branches      42730    42761      +31     
============================================
+ Hits         209478   209759     +281     
+ Misses        66236    66101     -135     
- Partials      17554    17612      +58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 0142fab into 2.x Jul 10, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Add unit tests for read flow of RemoteClusterStateService and bug fix…
9ca33ec 
… for transient settings (opensearch-project#14476) (opensearch-project#14705)

(cherry picked from commit b068355)

Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@dbwiddis dbwiddis deleted the backport/backport-14476-to-2.x branch July 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah

1 more reviewer

@dblock dblock dblock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dblock