Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving DCO to workflows #1458

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Moving DCO to workflows #1458

merged 1 commit into from
Oct 28, 2021

Conversation

CEHENKLE
Copy link
Member

Signed-off-by: CEHENKLE henkle@amazon.com

Description

Adds DCO to workflows

Issues Resolved

#1318

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@CEHENKLE
Copy link
Member Author

@peternied @peterzhuamazon Can/Should we turn off Jenkins before we merge this?

Thanks!

/C

@CEHENKLE
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 033e25dc773667e6ce79deeaeca058557146fb10

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 033e25dc773667e6ce79deeaeca058557146fb10

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 033e25dc773667e6ce79deeaeca058557146fb10

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 033e25dc773667e6ce79deeaeca058557146fb10
Log 848

Reports 848

@peternied
Copy link
Member

@peternied @peterzhuamazon Can/Should we turn off Jenkins before we merge this?

/C

We can disable the jenkins job after we merge - 2 DCO checks are better than none. I'll watch this issue and disable the legacy job when I see both are operational

@peternied
Copy link
Member

@CEHENKLE It looks like the github action didn't trigger because of backend settings approving github action sources

tim-actions/get-pr-commits@v1.1.0 and tim-actions/dco@v1.1.0 are not allowed to be used in opensearch-project/OpenSearch.  Actions in this workflow must be: within a repository that belongs to your Enterprise account, verified in the GitHub Marketplace or match the following: lycheeverse/lychee-action@master.

I've whitelisted those actions in this repo. Could you commit --amend and force push your branch so it triggers the github action?

@CEHENKLE
Moving DCO to workflows
766108f 
Signed-off-by: CEHENKLE <henkle@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 766108f

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 766108f

@CEHENKLE
Copy link
Member Author

Ooo Shiny ;)

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 766108f

@adnapibar
Copy link
Contributor

Can we merge this without running gradle check?

adnapibar
adnapibar approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@adnapibar adnapibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@peternied
Copy link
Member

start gradle check

@peternied
Copy link
Member

@peterzhuamazon It looks like the gradle check is stuck - can you take a look?

@peterzhuamazon
Copy link
Member

start gradle check

@peterzhuamazon
Copy link
Member

Not stuck, triggered normally running now.

@peterzhuamazon
Copy link
Member

I removed DCO check from jenkins as a requirement.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 766108f
Log 856

Reports 856

@peterzhuamazon
Copy link
Member

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 766108f
Log 859

Reports 859

peterzhuamazon
peterzhuamazon reviewed Oct 28, 2021
View reviewed changes
Copy link
Member

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@peterzhuamazon peterzhuamazon merged commit f08ee2c into opensearch-project:main Oct 28, 2021
@dblock dblock added backport 1.x pending backport Identifies an issue or PR that still needs to be backported labels Dec 7, 2021
@dblock dblock mentioned this pull request Dec 7, 2021
Merged
1 task
dblock pushed a commit to dblock/OpenSearch that referenced this pull request Dec 7, 2021
@CEHENKLE @dblock
Moving DCO to workflows (opensearch-project#1458)
0a1c807 
Signed-off-by: CEHENKLE <henkle@amazon.com>
dblock added a commit that referenced this pull request Dec 8, 2021
@dblock @CEHENKLE
Moving DCO to workflows (#1458) (#1666)
1c598d1 
Signed-off-by: CEHENKLE <henkle@amazon.com>

Co-authored-by: CEHENKLE <henkle@amazon.com>
@saratvemulapalli saratvemulapalli mentioned this pull request Dec 14, 2021
Merged
1 task
dblock pushed a commit to dblock/OpenSearch that referenced this pull request Dec 14, 2021
@CEHENKLE @dblock
Moving DCO to workflows (opensearch-project#1458)
dcb0b70 
Signed-off-by: CEHENKLE <henkle@amazon.com>
dblock added a commit that referenced this pull request Dec 15, 2021
@dblock @reta @CEHENKLE
Increment version to 1.2.2 and backport log4j upgrade to 2.16. (#1728)
123d41c 
* Increment version to 1.2.2.

Signed-off-by: dblock <dblock@amazon.com>

* Upgrade to log4j 2.16.0 (#1721) (#1723)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Moving DCO to workflows (#1458)

Signed-off-by: CEHENKLE <henkle@amazon.com>

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: CEHENKLE <henkle@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhuamazon peterzhuamazon peterzhuamazon left review comments

@adnapibar adnapibar adnapibar approved these changes

@peternied peternied peternied approved these changes

Assignees
No one assigned
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CEHENKLE @opensearch-ci-bot @peternied @adnapibar @peterzhuamazon @dblock