Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Star tree codec changes #14514
Star tree codec changes #14514
Changes from 1 commit
bbaa1c7
28e895c
d0e325a
5457301
d9d75be
8430db2
d10acbb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 84 in server/src/main/java/org/opensearch/index/codec/CodecService.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/CodecService.java#L81-L84
Check warning on line 43 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java#L42-L43
Check warning on line 47 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java#L46-L47
Check warning on line 53 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java#L50-L53
Check warning on line 57 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java#L57
Check warning on line 62 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesFormat.java#L62
Check warning on line 41 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L38-L41
Check warning on line 43 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L43
Check warning on line 47 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L47
Check warning on line 52 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L52
Check warning on line 57 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L57
Check warning on line 62 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L62
Check warning on line 67 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L67
Check warning on line 72 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L72
Check warning on line 74 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L74
Check warning on line 78 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L78
Check warning on line 80 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L80
Check warning on line 85 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L85
Check warning on line 92 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesReader.java#L92
Check warning on line 37 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L37
Check warning on line 42 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L41-L42
Check warning on line 45 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L45
Check warning on line 51 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L47-L51
Check warning on line 55 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L53-L55
Check warning on line 60 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L59-L60
Check warning on line 65 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L64-L65
Check warning on line 70 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L69-L70
Check warning on line 74 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L74
Check warning on line 77 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L77
Check warning on line 79 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L79
Check warning on line 84 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L83-L84
Check warning on line 89 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L89
Check warning on line 96 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L94-L96
Check warning on line 104 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L104
Check warning on line 106 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L106
Check warning on line 112 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L111-L112
Check warning on line 115 in server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite90DocValuesWriter.java#L115
Check warning on line 33 in server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java#L32-L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bharath-techie @msfroh I think we have an issue here with
PerFieldMappingPostingFormatCodec
, as per invariants,PerFieldMappingPostingFormatCodec
always uses the latest available codecbut
Composite99Codec
is explicitly bound to Lucene 9.9 (the latest for the current Apache Lucene version). I think we need to make changes here while it is not too late (Apache Lucene 9.12 comes with new codecs)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reta I believe that should be fine.
Lets consider the case when we upgrade to Lucene-912.
For reference, this is how the custom-codecs plugin handles this as well.
Check warning on line 37 in server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java#L36-L37
Check warning on line 50 in server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java#L48-L50
Check warning on line 54 in server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java
Codecov / codecov/patch
server/src/main/java/org/opensearch/index/codec/composite/Composite99Codec.java#L54