Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Writable Warm] Composite Directory implementation and integrating it with FileCache #14489

Merged
merged 2 commits into from
Jun 24, 2024

Commits on Jun 21, 2024

  1. [Writable Warm] Composite Directory implementation and integrating it…

    … with FileCache (opensearch-project#12782)
    
    * Composite Directory POC
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Refactor TransferManager interface to RemoteStoreFileTrackerAdapter
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Implement block level fetch for Composite Directory
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Removed CACHE state from FileTracker
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Fixes after latest pull
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Add new setting for warm, remove store type setting, FileTracker and RemoteStoreFileTrackerAdapter, CompositeDirectoryFactory and update Composite Directory implementation
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Modify TransferManager - replace BlobContainer with Functional Interface to fetch an InputStream instead
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Reuse OnDemandBlockSnapshotIndexInput instead of OnDemandBlockCompositeIndexInput
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Modify constructors to avoid breaking public api contract and code review fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Add experimental annotations for newly created classes and review comment fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Use ref count as a temporary measure to prevent file from eviction until uploaded to Remote
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Remove method level locks
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Handle tmp file deletion
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Nit fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Handle delete and close in Composite Directory, log current state of FileCache and correct it's clear method and modify unit and integration tests as per review comments
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Refactor usages of WRITEABLE_REMOTE_INDEX_SETTING to TIERED_REMOTE_INDEX_SETTING
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Add tests for FileCachedIndexInput and review comment fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Add additional IT for feature flag disabled
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Move setting for Partial Locality type behind Feature Flag, fix bug for ref count via cloneMap in FullFileCachedIndexInput and other review fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Minor test and nit fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Add javadocs for FullFileCachedIndexInput
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    * Minor precommit fixes
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    
    ---------
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    rayshrey committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    b42a50e View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Fix Writable Warm test for feature flag disabled condition by changin…

    …g exception type caught
    
    Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
    rayshrey committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    e6c3b57 View commit details
    Browse the repository at this point in the history