Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix incorrect document order when there's exception during batch ingest #14341

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

chishui
Copy link
Contributor

@chishui chishui commented Jun 14, 2024

Description

This is to fix a document incorrect order bug with batch ingestion when some docs run into exception.

bug is described here: #14336
the integration test here #14335 was also added.

Skip changelog and backport to 2.x

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for f54f43a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@chishui
Copy link
Contributor Author

chishui commented Jun 14, 2024

❌ Gradle check result for f54f43a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

> Task :server:test

Tests with failures:
 - org.opensearch.index.shard.IndexShardTests.testRefreshLevelRestoreShardFromRemoteStore

13137 tests completed, 1 failed, 32 skipped

open flaky issue #10785

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Copy link
Contributor

❌ Gradle check result for 02dde2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@chishui
Copy link
Contributor Author

chishui commented Jun 14, 2024

❌ Gradle check result for 02dde2a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Tests with failures:

  • org.opensearch.indices.IndicesRequestCacheIT.testQueryRewriteDates {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}}
  • org.opensearch.indices.IndicesRequestCacheIT.classMethod

#14288

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Copy link
Contributor

❕ Gradle check result for 5ed3400: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.73%. Comparing base (b15cb0c) to head (5ed3400).
Report is 426 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14341      +/-   ##
============================================
+ Coverage     71.42%   71.73%   +0.31%     
- Complexity    59978    62086    +2108     
============================================
  Files          4985     5117     +132     
  Lines        282275   291712    +9437     
  Branches      40946    42168    +1222     
============================================
+ Hits         201603   209253    +7650     
- Misses        63999    65193    +1194     
- Partials      16673    17266     +593     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit d480027 into opensearch-project:main Jun 14, 2024
33 of 39 checks passed
@andrross
Copy link
Member

@chishui Can you send out a PR to address my comments about the tests?

@andrross andrross added backport 2.x Backport to 2.x branch backport 2.15 v2.15.0 Issues and PRs related to version 2.15.0 labels Jun 14, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
…atch ingest (#14341)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
(cherry picked from commit d480027)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 14, 2024
…atch ingest (#14341)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
(cherry picked from commit d480027)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@chishui
Copy link
Contributor Author

chishui commented Jun 14, 2024

@chishui Can you send out a PR to address my comments about the tests?

will do

andrross pushed a commit that referenced this pull request Jun 14, 2024
…atch ingest (#14341) (#14359)

(cherry picked from commit d480027)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request Jun 17, 2024
…atch ingest (#14341) (#14358)

(cherry picked from commit d480027)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…atch ingest (opensearch-project#14341) (opensearch-project#14358)

(cherry picked from commit d480027)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…atch ingest (opensearch-project#14341)

Signed-off-by: Liyun Xiu <xiliyun@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.15 skip-changelog v2.15.0 Issues and PRs related to version 2.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants