Skip to content

[Backport] [2.x] [Streaming Indexing] Enhance RestAction with request / response streaming support (#13772) #14149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

[Backport] [2.x] [Streaming Indexing] Enhance RestAction with request / response streaming support (#13772) #14149

merged 1 commit into from
Jun 11, 2024

Conversation

@reta
Copy link
Contributor

@reta reta commented Jun 10, 2024

Backport of #13772 to 2.x

@reta
[Streaming Indexing] Enhance RestAction with request / response strea…
6e07337 
…ming support (opensearch-project#13772)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit c71060e)
@reta reta added backport PRs or issues specific to backporting features or enhancments v2.15.0 Issues and PRs related to version 2.15.0 labels Jun 10, 2024
@github-actions
Copy link
Contributor

✅ Gradle check result for 6e07337: SUCCESS

@codecov
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 46.09929% with 152 lines in your changes missing coverage. Please review.

Project coverage is 71.42%. Comparing base (0dd892c) to head (6e07337).
Report is 339 commits behind head on 2.x.

Files Patch % Lines
.../main/java/org/opensearch/rest/RestController.java 1.88% 51 Missing and 1 partial ⚠️
.../rest/action/document/RestBulkStreamingAction.java 31.74% 42 Missing and 1 partial ⚠️
...ctor/netty4/ReactorNetty4StreamingHttpChannel.java 36.84% 23 Missing and 1 partial ⚠️
...g/opensearch/http/DefaultStreamingRestChannel.java 64.28% 7 Missing and 3 partials ⚠️
.../netty4/ReactorNetty4StreamingRequestConsumer.java 61.53% 3 Missing and 2 partials ⚠️
...ch/http/reactor/netty4/ReactorNetty4HttpChunk.java 69.23% 3 Missing and 1 partial ⚠️
...netty4/ReactorNetty4StreamingResponseProducer.java 75.00% 4 Missing ⚠️
.../src/main/java/org/opensearch/http/HttpTracer.java 0.00% 4 Missing ⚠️
...g/opensearch/http/AbstractHttpServerTransport.java 62.50% 3 Missing ⚠️
...rch/common/xcontent/support/XContentHttpChunk.java 83.33% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14149      +/-   ##
============================================
+ Coverage     71.28%   71.42%   +0.14%     
- Complexity    60145    61916    +1771     
============================================
  Files          4957     5079     +122     
  Lines        282799   290664    +7865     
  Branches      41409    42359     +950     
============================================
+ Hits         201591   207617    +6026     
- Misses        64189    65586    +1397     
- Partials      17019    17461     +442

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Contributor Author

reta commented Jun 11, 2024

@dblock @andrross if you don't mind folks, backport to 2.x, thank you

@dblock dblock merged commit 159770e into opensearch-project:2.x Jun 11, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@reta @kkewwei
[Streaming Indexing] Enhance RestAction with request / response strea…
11cc4fa 
…ming support (opensearch-project#13772) (opensearch-project#14149)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit c71060e)
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

1 more reviewer

@dblock dblock dblock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport PRs or issues specific to backporting features or enhancments v2.15.0 Issues and PRs related to version 2.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reta @dblock