Skip to content

[Backport 2.x] Pass parent filter to inner hit query (#13903) #13906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2024
Merged

[Backport 2.x] Pass parent filter to inner hit query (#13903) #13906

merged 2 commits into from
May 31, 2024

Conversation

@heemin32
Copy link
Contributor

@heemin32 heemin32 commented May 31, 2024 •
edited
Loading

Description

This PR backports #13903

@heemin32 heemin32 mentioned this pull request May 31, 2024
Merged
9 tasks
msfroh
msfroh reviewed May 31, 2024
View reviewed changes
@heemin32 heemin32 force-pushed the backport-13903-to-2.x branch from 75a3b93 to c6f1235 Compare May 31, 2024 01:35
@github-actions
Copy link
Contributor

❌ Gradle check result for dc76830: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@heemin32
Pass parent filter to inner hit query (opensearch-project#13903)
05618e2 
Signed-off-by: Heemin Kim <heemin@amazon.com>
(cherry picked from commit 6c9603a)
@heemin32 heemin32 force-pushed the backport-13903-to-2.x branch from c6f1235 to 05618e2 Compare May 31, 2024 01:38
@heemin32
Merge branch '2.x' into backport-13903-to-2.x
215b684 
Signed-off-by: Heemin Kim <heemin@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for c6f1235: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@heemin32 heemin32 requested a review from msfroh May 31, 2024 02:02
@github-actions
Copy link
Contributor

❌ Gradle check result for 05618e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 75a3b93: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 215b684: SUCCESS

@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.35%. Comparing base (0dd892c) to head (215b684).
Report is 284 commits behind head on 2.x.

Files Patch % Lines
...org/opensearch/index/query/NestedQueryBuilder.java 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #13906      +/-   ##
============================================
+ Coverage     71.28%   71.35%   +0.06%     
- Complexity    60145    61371    +1226     
============================================
  Files          4957     5038      +81     
  Lines        282799   288399    +5600     
  Branches      41409    42135     +726     
============================================
+ Hits         201591   205784    +4193     
- Misses        64189    65285    +1096     
- Partials      17019    17330     +311

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh merged commit a6c86e7 into opensearch-project:2.x May 31, 2024
This was referenced Jun 18, 2024
Open
Closed
This was referenced Jun 27, 2024
Open
Closed
Open
Open
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@heemin32 @kkewwei
Pass parent filter to inner hit query (opensearch-project#13903) (ope…
0268ce4 
…nsearch-project#13906)

Signed-off-by: kkewwei <kkewwei@163.com>
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Nov 7, 2024
Closed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msfroh msfroh msfroh approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heemin32 @msfroh