[Bugfix] [Tiered Caching] Add segmented locks to TieredSpilloverCache #13901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In performance benchmarking of tiered caching we found the TSC spends a lot of its time waiting on a single global read-write lock, which blocks access to the underlying cache. This lock is meant to prevent keys from entering both the on-heap and disk tier simultaneously; the underlying tiers themselves are threadsafe.
To resolve this, we effectively segment the TSC with 256 locks. To do a cache operation with a key, you must acquire the corresponding lock, which is determined by key.hashCode(). This way most pairs of keys can access the cache concurrently.
Related Issues
Part of tiered caching.
Check List
- [N/A] API changes companion pull request created.- [N/A] Commit changes are listed out in CHANGELOG.md file (See: Changelog)- [N/A] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.