add resourceLimitGroupTests

Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>

server/src/main/java/org/opensearch/cluster/metadata/ResourceLimitGroup.java

@@ -39,6 +39,7 @@
 @ExperimentalApi
 public class ResourceLimitGroup extends AbstractDiffable<ResourceLimitGroup> implements ToXContentObject {
 
+    public static final int MAX_CHARS_ALLOWED_IN_NAME = 50;
     private final String name;
     private final List<ResourceLimit> resourceLimits;
 
@@ -59,7 +60,18 @@ public class ResourceLimitGroup extends AbstractDiffable<ResourceLimitGroup> imp
         PARSER.declareObjectArray(ConstructingObjectParser.constructorArg(), (p, c) -> ResourceLimit.fromXContent(p), RESOURCE_LIMITS_FIELD);
     }
 
-    public ResourceLimitGroup(String name, List<ResourceLimit> resourceLimits) {
+    public ResourceLimitGroup(final String name, final List<ResourceLimit> resourceLimits) {
+        Objects.requireNonNull(name, "ResourceLimitGroup.name can't be null");
+        Objects.requireNonNull(resourceLimits, "ResourceLimitGroup.resourceLimits can't be null");
+
+        if (name.length() > MAX_CHARS_ALLOWED_IN_NAME) {
+            throw new IllegalArgumentException("ResourceLimitGroup.name shouldn't be more than 50 chars long");
+        }
+
+        if (resourceLimits.isEmpty()) {
+            throw new IllegalArgumentException("ResourceLimitGroup.resourceLimits should at least have 1 resource limit");
+        }
+
         this.name = name;
         this.resourceLimits = resourceLimits;
     }
@@ -208,4 +220,8 @@ public int hashCode() {
     public String getName() {
         return name;
     }
+
+    public List<ResourceLimit> getResourceLimits() {
+        return resourceLimits;
+    }
 }

server/src/main/java/org/opensearch/common/settings/ClusterSettings.java

@@ -157,6 +157,10 @@
 import org.opensearch.search.backpressure.settings.SearchShardTaskSettings;
 import org.opensearch.search.backpressure.settings.SearchTaskSettings;
 import org.opensearch.search.fetch.subphase.highlight.FastVectorHighlighter;
+<<<<<<< HEAD
+=======
+import org.opensearch.search.resource_limit_group.ResourceLimitGroupServiceSettings;
+>>>>>>> ba237c14d3f (add resourceLimitGroupTests)
 import org.opensearch.snapshots.InternalSnapshotsInfoService;
 import org.opensearch.snapshots.SnapshotsService;
 import org.opensearch.tasks.TaskCancellationMonitoringSettings;

server/src/test/java/org/opensearch/cluster/metadata/ResourceLimitGroupTests.java

@@ -0,0 +1,103 @@
+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ */
+
+package org.opensearch.cluster.metadata;
+
+import org.opensearch.core.common.io.stream.Writeable;
+import org.opensearch.core.xcontent.XContentParser;
+import org.opensearch.test.AbstractSerializingTestCase;
+
+import java.io.IOException;
+import java.util.List;
+
+public class ResourceLimitGroupTests extends AbstractSerializingTestCase<ResourceLimitGroup> {
+
+
+    private ResourceLimitGroup createRandomResourceLimitGroup() {
+        String name = randomAlphaOfLength(10);
+        ResourceLimitGroup.ResourceLimit resourceLimit =  new ResourceLimitGroup.ResourceLimit("jvm",
+            randomDoubleBetween(0.0, 0.80, false));
+        return new ResourceLimitGroup(name, List.of(resourceLimit));
+    }
+
+    /**
+     * Parses to a new instance using the provided {@link XContentParser}
+     *
+     * @param parser
+     */
+    @Override
+    protected ResourceLimitGroup doParseInstance(XContentParser parser) throws IOException {
+        return ResourceLimitGroup.fromXContent(parser);
+    }
+
+    /**
+     * Returns a {@link Writeable.Reader} that can be used to de-serialize the instance
+     */
+    @Override
+    protected Writeable.Reader<ResourceLimitGroup> instanceReader() {
+        return ResourceLimitGroup::new;
+    }
+
+    /**
+     * Creates a random test instance to use in the tests. This method will be
+     * called multiple times during test execution and should return a different
+     * random instance each time it is called.
+     */
+    @Override
+    protected ResourceLimitGroup createTestInstance() {
+        return createRandomResourceLimitGroup();
+    }
+
+    public void testNullName() {
+        assertThrows(NullPointerException.class,
+            () -> new ResourceLimitGroup(null, List.of()));
+    }
+
+    public void testNullResourceLimits() {
+        assertThrows(NullPointerException.class,
+            () -> new ResourceLimitGroup("analytics", null));
+    }
+
+    public void testEmptyResourceLimits() {
+        assertThrows(IllegalArgumentException.class,
+            () -> new ResourceLimitGroup("analytics", List.of()));
+    }
+
+    public void testInvalidResourceLimitWhenInvalidSystemResourceNameIsGiven() {
+        assertThrows(IllegalArgumentException.class, () -> new ResourceLimitGroup(
+            "analytics",
+            List.of(
+                new ResourceLimitGroup.ResourceLimit("RequestRate", randomDoubleBetween(0.01, 0.8, false))
+            )
+        ));
+    }
+
+    public void testInvalidResourceLimitWhenInvalidSystemResourceValueIsGiven() {
+        assertThrows(IllegalArgumentException.class, () -> new ResourceLimitGroup(
+            "analytics",
+            List.of(
+                new ResourceLimitGroup.ResourceLimit("RequestRate", randomDoubleBetween(1.1, 1.8, false))
+            )
+        ));
+    }
+
+    public void testValidResourceLimitGroup() {
+        ResourceLimitGroup resourceLimitGroup = new ResourceLimitGroup(
+            "analytics",
+            List.of(
+                new ResourceLimitGroup.ResourceLimit("jvm", randomDoubleBetween(0.01, 0.8, false))
+            )
+        );
+
+        assertNotNull(resourceLimitGroup.getName());
+        assertEquals("analytics", resourceLimitGroup.getName());
+        assertNotNull(resourceLimitGroup.getResourceLimits());
+        assertFalse(resourceLimitGroup.getResourceLimits().isEmpty());
+        assertEquals(1, resourceLimitGroup.getResourceLimits().size());
+    }
+}

server/src/test/java/org/opensearch/search/sandbox/ResourceLimitGroupServiceSettingsTests.java

@@ -10,11 +10,12 @@
 
 import org.opensearch.common.settings.ClusterSettings;
 import org.opensearch.common.settings.Settings;
+import org.opensearch.search.resource_limit_group.ResourceLimitGroupServiceSettings;
 import org.opensearch.test.OpenSearchTestCase;
 
-import static org.opensearch.search.sandbox.ResourceLimitGroupServiceSettings.NODE_CANCELLATION_THRESHOLD_SETTING_NAME;
-import static org.opensearch.search.sandbox.ResourceLimitGroupServiceSettings.NODE_REJECTION_THRESHOLD_SETTING_NAME;
-import static org.opensearch.search.sandbox.ResourceLimitGroupServiceSettings.RESOURCE_LIMIT_GROUP_COUNT_SETTING_NAME;
+import static org.opensearch.search.resource_limit_group.ResourceLimitGroupServiceSettings.NODE_CANCELLATION_THRESHOLD_SETTING_NAME;
+import static org.opensearch.search.resource_limit_group.ResourceLimitGroupServiceSettings.NODE_REJECTION_THRESHOLD_SETTING_NAME;
+import static org.opensearch.search.resource_limit_group.ResourceLimitGroupServiceSettings.RESOURCE_LIMIT_GROUP_COUNT_SETTING_NAME;
 
 public class ResourceLimitGroupServiceSettingsTests extends OpenSearchTestCase {