Skip to content

[Remote Store] Upload translog checkpoint as object metadata to translog #13637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 23, 2024
Merged

[Remote Store] Upload translog checkpoint as object metadata to translog #13637

merged 15 commits into from
May 23, 2024

Conversation

@skumawat2025
Copy link
Contributor

@skumawat2025 skumawat2025 commented May 13, 2024 •
edited
Loading

Previous PR link: #13272

Description

This PR is a sub task of feature request #13022. And is being tracked here #13091.

This PR include below changes -

  1. We introduced a new key (translog-metadata) in remote store custom metadata for new indices.
  2. For the indices having translog-metadata as true, the translog.ckp file's data is now stored as object metadata associated with the translog.tlog file when uploading to an S3 remote storage.
  3. We will make only one download calls for translog.tlog file with it's metadata to recover translog files for a generation.
  4. Handling of translog file deletion calls.

Related Issues

Resolves #13094

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Performance Storage:Remote v2.14.0 labels May 13, 2024
@skumawat2025 skumawat2025 self-assigned this May 13, 2024
@github-actions
Copy link
Contributor

❌ Gradle check result for c20ae47: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025 skumawat2025 changed the title initial commits Translog Optimisation May 13, 2024
@skumawat2025
initial commits
6724043 
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 6724043: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for b07035e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025
upload translog ckp file as object metadata to translog tlog file
fc368da 
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for fc368da: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 7586b7d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@skumawat2025
address comments and add ut's
b53a30e 
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
@skumawat2025 skumawat2025 marked this pull request as ready for review May 14, 2024 12:59
@skumawat2025 skumawat2025 mentioned this pull request May 23, 2024
Merged
8 tasks
skumawat2025 added a commit to skumawat2025/OpenSearch that referenced this pull request May 23, 2024
@skumawat2025
[Remote Store] Upload translog checkpoint as object metadata to trans…
de4e20c 
…log (opensearch-project#13637)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
sachinpkale pushed a commit that referenced this pull request May 23, 2024
@skumawat2025
[Remote Store] Upload translog checkpoint as object metadata to trans…
edcbdaf 
…log (#13637) (#13795)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
@skumawat2025 @parv0201
[Remote Store] Upload translog checkpoint as object metadata to trans…
192541f 
…log (opensearch-project#13637)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
@finnegancarroll finnegancarroll mentioned this pull request Jun 14, 2024
Merged
3 tasks
@prudhvigodithi prudhvigodithi mentioned this pull request Jun 18, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jun 26, 2024
Merged
This was referenced Jun 27, 2024
Closed
Open
Closed
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@skumawat2025 @kkewwei
[Remote Store] Upload translog checkpoint as object metadata to trans…
b9ff6db 
…log (opensearch-project#13637) (opensearch-project#13795)

* Upload translog checkpoint as object metadata to translog
Signed-off-by: Sandeep Kumawat <2025sandeepkumawat@gmail.com>
Signed-off-by: kkewwei <kkewwei@163.com>
@gbbafna gbbafna mentioned this pull request Jul 31, 2024
Merged
2 tasks
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 6, 2024
Open
This was referenced Oct 1, 2024
Open
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Feb 14, 2025
Closed
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 13, 2025
Open
@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Aug 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bukhtawar Bukhtawar Bukhtawar left review comments

@sachinpkale sachinpkale sachinpkale approved these changes

@ashking94 ashking94 ashking94 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

Assignees

@skumawat2025 skumawat2025

Labels

backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Storage:Performance Storage:Remote v2.15.0 Issues and PRs related to version 2.15.0

Projects

Storage Project Board
Status: ✅ Done

Milestone

No milestone

5 participants

@skumawat2025 @shourya035 @sachinpkale @ashking94 @Bukhtawar