Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Tiered Caching] Expose a dynamic setting to disable/enable disk cache #13403

Merged

Conversation

sgup432
Copy link
Contributor

@sgup432 sgup432 commented Apr 26, 2024

Description

Backport #13373

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-project#13373)

* [Tiered Caching] Expose a dynamic setting to disable/enable disk cache

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* Putting tiered cache settings behind feature flag

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* Adding a changelog

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* Addressing Sorabh's comments

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

* Putting new setting behind feature flag

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>

---------

Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com>
@sgup432
Copy link
Contributor Author

sgup432 commented Apr 26, 2024

@sohami

Copy link
Contributor

❌ Gradle check result for 93bfc5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator

sohami commented Apr 26, 2024

❌ Gradle check result for 93bfc5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known Flaky Test: #13045

Copy link
Contributor

❌ Gradle check result for 93bfc5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator

sohami commented Apr 26, 2024

❌ Gradle check result for 93bfc5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known Flaky Test: #13106

@sgup432 sgup432 changed the title [Tiered Caching] Expose a dynamic setting to disable/enable disk cache [Backport 2.x] [Tiered Caching] Expose a dynamic setting to disable/enable disk cache Apr 26, 2024
Copy link
Contributor

❌ Gradle check result for 93bfc5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator

sohami commented Apr 27, 2024

❌ Gradle check result for 93bfc5f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known Flaky Test:
#12639
#2440

Copy link
Contributor

❕ Gradle check result for 93bfc5f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.04%. Comparing base (0dd892c) to head (93bfc5f).
Report is 192 commits behind head on 2.x.

Files Patch % Lines
...search/cache/common/tier/TieredSpilloverCache.java 94.11% 2 Missing ⚠️
.../cache/common/tier/TieredSpilloverCachePlugin.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13403      +/-   ##
============================================
- Coverage     71.28%   71.04%   -0.24%     
- Complexity    60145    60701     +556     
============================================
  Files          4957     5013      +56     
  Lines        282799   285879    +3080     
  Branches      41409    41792     +383     
============================================
+ Hits         201591   203117    +1526     
- Misses        64189    65621    +1432     
- Partials      17019    17141     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sohami sohami merged commit aa50a60 into opensearch-project:2.x Apr 27, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants