-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Tiered Caching] Expose a dynamic setting to disable/enable disk cache #13403
[Backport 2.x] [Tiered Caching] Expose a dynamic setting to disable/enable disk cache #13403
Conversation
opensearch-project#13373) * [Tiered Caching] Expose a dynamic setting to disable/enable disk cache Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Putting tiered cache settings behind feature flag Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Adding a changelog Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Addressing Sorabh's comments Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> * Putting new setting behind feature flag Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com> Signed-off-by: Sagar <99425694+sgup432@users.noreply.github.com>
❌ Gradle check result for 93bfc5f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known Flaky Test: #13045 |
❌ Gradle check result for 93bfc5f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Known Flaky Test: #13106 |
❌ Gradle check result for 93bfc5f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 93bfc5f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13403 +/- ##
============================================
- Coverage 71.28% 71.04% -0.24%
- Complexity 60145 60701 +556
============================================
Files 4957 5013 +56
Lines 282799 285879 +3080
Branches 41409 41792 +383
============================================
+ Hits 201591 203117 +1526
- Misses 64189 65621 +1432
- Partials 17019 17141 +122 ☔ View full report in Codecov by Sentry. |
Description
Backport #13373
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.