Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add capability of doing flush as determined by the tra… #13378

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

astute-decipher
Copy link
Contributor

…nslog (#12992)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 20b65c7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for c9e2677: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 05fec43: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Copy link
Contributor

❕ Gradle check result for d3b6c2f: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Copy link
Contributor

❕ Gradle check result for ba9f80d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=indices.get_field_mapping/20_missing_field/Return empty object if field doesn't exist, but index does}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Signed-off-by: Shubh Sahu <shubhvs@amazon.com>
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 71.28%. Comparing base (0dd892c) to head (0450c67).
Report is 210 commits behind head on 2.x.

Files Patch % Lines
...search/index/translog/InternalTranslogManager.java 0.00% 1 Missing and 1 partial ⚠️
...rg/opensearch/index/translog/RemoteFsTranslog.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##                2.x   #13378     +/-   ##
===========================================
  Coverage     71.28%   71.28%             
- Complexity    60145    61057    +912     
===========================================
  Files          4957     5024     +67     
  Lines        282799   287028   +4229     
  Branches      41409    41939    +530     
===========================================
+ Hits         201591   204610   +3019     
- Misses        64189    65177    +988     
- Partials      17019    17241    +222     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for 0450c67: SUCCESS

@gbbafna gbbafna merged commit 400a8a2 into opensearch-project:2.x Apr 30, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants