Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x][Tiered Caching] Bug fix for IndicesRequestCache StaleKey management #13370

Closed
wants to merge 6 commits into from
Closed

[Backport 2.x][Tiered Caching] Bug fix for IndicesRequestCache StaleKey management #13370

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e27e46
[Tiered Caching] Bug fix for IndicesRequestCache StaleKey management …
kiranprakash154 Apr 24, 2024
a003c7e
resolve conflicts
kiranprakash154 Apr 25, 2024
d91eb48
resolve conflicts
kiranprakash154 Apr 25, 2024
4b345ab
resolve conflicts
kiranprakash154 Apr 25, 2024
e12b12f
spotless
kiranprakash154 Apr 25, 2024
98c664c
bug
kiranprakash154 Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bug 
Signed-off-by: Kiran Prakash <awskiran@amazon.com>
  • Loading branch information
@kiranprakash154
kiranprakash154 committed Apr 25, 2024
commit 98c664c0dc77f858c6a3a7569608273adf815356
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/indices/IndicesRequestCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ public void onRemoval(RemovalNotification<Key, BytesReference> notification) {
Key key = notification.getKey();
cacheEntityLookup.apply(key.shardId).ifPresent(entity -> entity.onRemoval(notification));
CleanupKey cleanupKey = new CleanupKey(cacheEntityLookup.apply(key.shardId).orElse(null), key.readerCacheKeyId);
cacheCleanupManager.updateStaleCountOnEntryRemoval(cleanupKey, newNotification);
cacheCleanupManager.updateStaleCountOnEntryRemoval(cleanupKey, notification);
}

BytesReference getOrCompute(
Expand Down
Loading