-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled mockTelemetryPlugin for IT and fixed OOM #13054
Conversation
Compatibility status:Checks if related components are compatible with change 82d63bc Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13054 +/- ##
============================================
+ Coverage 71.42% 71.57% +0.15%
- Complexity 59978 60758 +780
============================================
Files 4985 5040 +55
Lines 282275 285416 +3141
Branches 40946 41335 +389
============================================
+ Hits 201603 204294 +2691
- Misses 63999 64256 +257
- Partials 16673 16866 +193 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for 6ec2e3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 2e921a6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@reta Can you please check if it looks good? |
Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com>
❕ Gradle check result for 82d63bc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
.../telemetry/src/main/java/org/opensearch/test/telemetry/tracing/StrictCheckSpanProcessor.java
Show resolved
Hide resolved
Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com>
Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com>
❌ Gradle check result for 15629fc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for ceb20cc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 16db035: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for ceb20cc: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13054-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 51009b76d480ac5b03b667b6282a987d0695ca2f
# Push it to GitHub
git push --set-upstream origin backport/backport-13054-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@atharvasharma61 could you please backport to |
…13054) * Disable stackTrace in MockSpanData by default Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * enabled MockTelemetryPlugin for ITs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added the flag as system property Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Applied java spotless check Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added details in changelog Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added details in TESTING.md Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Update TESTING.md Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> (cherry picked from commit 51009b7)
* Disable stackTrace in MockSpanData by default Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * enabled MockTelemetryPlugin for ITs Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added the flag as system property Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Applied java spotless check Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added details in changelog Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Added details in TESTING.md Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> * Update TESTING.md Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> --------- Signed-off-by: Atharva Sharma <atharvasharma61@gmail.com> Signed-off-by: Atharva Sharma <60044988+atharvasharma61@users.noreply.github.com> (cherry picked from commit 51009b7)
Description
PR to test OOM fix during ITs. Since a lot of spans are generated during the testing, by default, we are disabling the stackTraceElement data from the MockSpanData which aims to significantly reduce the memory usage. It can be re-enabled manually if needed for debugging purposes.
Related Issues
Resolves #12615
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.