Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradle check fail due to artifact renaming with "-min" #1289

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

xuezhou25
Copy link
Contributor

Signed-off-by: Xue Zhou xuezhou@amazon.com

Description

Fix gradle check failing due to artifact renaming in #1094.

Issues Resolved

#1285

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Xue Zhou <xuezhou@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 2ddf050

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 2ddf050

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 2ddf050

@tlfeng
Copy link
Collaborator

tlfeng commented Sep 24, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 2ddf050
Log 565

Reports 565

@xuezhou25
Copy link
Contributor Author

@dblock Could we merge this?

@nknize nknize self-requested a review September 24, 2021 17:02
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for unblocking the PRs @xuezhou25! LGTM

@nknize nknize added pending backport Identifies an issue or PR that still needs to be backported Build Libraries & Interfaces v2.0.0 Version 2.0.0 labels Sep 24, 2021
@nknize
Copy link
Collaborator

nknize commented Sep 24, 2021

Can you open a backport PR to 1.x? and we'll cherry-pick to 1.1 (no PR needed for 1.1)

@nknize nknize merged commit 82d1d0e into opensearch-project:main Sep 24, 2021
xuezhou25 added a commit to xuezhou25/OpenSearch that referenced this pull request Sep 24, 2021
@dblock
Copy link
Member

dblock commented Sep 24, 2021

Sorry I'm late to this, LGTM thanks for taking care of it @xuezhou25!

dblock pushed a commit that referenced this pull request Sep 24, 2021
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
nknize pushed a commit that referenced this pull request Sep 25, 2021
Signed-off-by: Xue Zhou <xuezhou@amazon.com>
@xuezhou25 xuezhou25 deleted the fix-bwc branch September 28, 2021 07:44
@dblock dblock removed the pending backport Identifies an issue or PR that still needs to be backported label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants