Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] [Tiered Caching] Serializers for ehcache (#12709) #12736

Merged
merged 20 commits into from
Mar 19, 2024
Merged

[Backport 2.x] [Tiered Caching] Serializers for ehcache (#12709) #12736

merged 20 commits into from
Mar 19, 2024

Conversation

peteralfonsi
Copy link
Contributor

Original PR: #12709

Signed-off-by: Peter Alfonsi petealft@amazon.com
Co-authored-by: Peter Alfonsi petealft@amazon.com
(cherry picked from commit 21b28f2)

Description

As part of tiered caching, adds a Serializer interface and implementations for BytesReference and IndicesRequestCache.Key. Also integrates these with EhcacheDiskCache. This is required for Ehcache to accept non-primitive keys or values.

Related Issues

Part of the tiered caching feature.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [N/A] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peteralfonsi
[Tiered Caching] Serializers for ehcache (opensearch-project#12709)
ec175e1 
Adds serializers and integrates them into ehcache disk cache

---------

Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Co-authored-by: Peter Alfonsi <petealft@amazon.com>
(cherry picked from commit 21b28f2)
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change 8a1ae8d

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ec175e1:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Peter Alfonsi added 2 commits March 18, 2024 15:09
Rerunning gradle checks
7a9a7ed 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Rerunning gradle checks
549a476 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 7a9a7ed:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
8c421de 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8c421de:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

andrross
andrross reviewed Mar 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Removed incorrect changelog line
95534ec 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 95534ec:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
4b69a81 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 4b69a81: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
164fad5 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 164fad5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peteralfonsi
Copy link
Contributor Author

#12743

Rerunning gradle checks
b481666 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b481666:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
fa31e26 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for fa31e26:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
1968ac7 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1968ac7:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
141d3e9 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 141d3e9:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Peter Alfonsi added 2 commits March 18, 2024 18:35
Rerunning gradle checks
b1971d2 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
Rerunning gradle checks
be6aa24 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for be6aa24: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
bd1f4a0 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b1971d2: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for bd1f4a0: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Rerunning gradle checks
8a1ae8d 
Signed-off-by: Peter Alfonsi <petealft@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8a1ae8d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 8a1ae8d: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 76.53061% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 71.33%. Comparing base (0dd892c) to head (8a1ae8d).
Report is 39 commits behind head on 2.x.

Files Patch % Lines
.../opensearch/cache/store/disk/EhcacheDiskCache.java 80.00% 12 Missing and 1 partial ⚠️
.../opensearch/indices/IRCKeyWriteableSerializer.java 52.94% 6 Missing and 2 partials ⚠️
...mon/cache/serializer/BytesReferenceSerializer.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #12736      +/-   ##
============================================
+ Coverage     71.28%   71.33%   +0.05%     
- Complexity    60145    60268     +123     
============================================
  Files          4957     4965       +8     
  Lines        282799   283254     +455     
  Branches      41409    41451      +42     
============================================
+ Hits         201591   202068     +477     
+ Misses        64189    64128      -61     
- Partials      17019    17058      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrross andrross merged commit a6e49ef into opensearch-project:2.x Mar 19, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VachaShah VachaShah VachaShah approved these changes

@andrross andrross andrross approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peteralfonsi @VachaShah @andrross