Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test in CardinalityWithRequestBreakerIT #11467

Closed
wants to merge 1 commit into from
Closed

Fix flaky test in CardinalityWithRequestBreakerIT #11467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...Test/java/org/opensearch/search/aggregations/metrics/CardinalityWithRequestBreakerIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
import org.opensearch.indices.breaker.HierarchyCircuitBreakerService;
import org.opensearch.search.aggregations.Aggregator;
import org.opensearch.search.aggregations.BucketOrder;
import org.opensearch.test.OpenSearchIntegTestCase;
import org.opensearch.test.ParameterizedOpenSearchIntegTestCase;

import java.util.Arrays;
Expand All @@ -54,6 +55,7 @@
import static org.opensearch.search.aggregations.AggregationBuilders.cardinality;
import static org.opensearch.search.aggregations.AggregationBuilders.terms;

@OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.SUITE)
Copy link
Collaborator

@reta reta Dec 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neetikasinghal apologies, how does it solve the issue? The Scope.SUITE is the default value for scope , is it overridden somewhere down the hierarchy? (I was not able to find where)

public class CardinalityWithRequestBreakerIT extends ParameterizedOpenSearchIntegTestCase {

public CardinalityWithRequestBreakerIT(Settings dynamicSettings) {
Expand All @@ -76,7 +78,6 @@ protected Settings featureFlagSettings() {
/**
* Test that searches using cardinality aggregations returns all request breaker memory.
*/
@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/10154")
public void testRequestBreaker() throws Exception {
final String requestBreaker = randomIntBetween(1, 10000) + "kb";
logger.info("--> Using request breaker setting: {}", requestBreaker);
Expand Down
Loading