Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky test MoreExpressionIT.testSpecialValueVariable in concurrent search path #11309

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

sohami
Copy link
Collaborator

@sohami sohami commented Nov 22, 2023

Description

Backport f4b25d6 from #11088.

Related Issues

Resolves #10079

Check List

  • New functionality includes testing.
    • All tests pass
      New functionality has been documented.
      New functionality has javadoc added
      Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
    Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…t search path (opensearch-project#11088)

* Fix flaky test MoreExpressionIT.testSpecialValueVariable in concurrent search path

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>

* Rename ReplaceableConstDoubleValueSource class to PerThreadReplaceableConstDoubleValueSource

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>

---------

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change c0cbb24

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

✅ Gradle check result for c0cbb24: SUCCESS

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (2494528) 71.04% compared to head (c0cbb24) 70.98%.

Files Patch % Lines
...on/PerThreadReplaceableConstDoubleValueSource.java 0.00% 11 Missing ⚠️
...arch/script/expression/ExpressionScriptEngine.java 0.00% 4 Missing ⚠️
...script/expression/ExpressionAggregationScript.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11309      +/-   ##
============================================
- Coverage     71.04%   70.98%   -0.06%     
+ Complexity    59111    59046      -65     
============================================
  Files          4869     4869              
  Lines        278654   278660       +6     
  Branches      40830    40831       +1     
============================================
- Hits         197982   197820     -162     
- Misses        63895    64096     +201     
+ Partials      16777    16744      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sohami sohami merged commit c5730ba into opensearch-project:2.x Nov 22, 2023
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants