Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make the gradle check comment more compact #11160

Merged

Conversation

andrross
Copy link
Member

@andrross andrross commented Nov 10, 2023

Backports dcb64d8 to 2.x from #11151

There were also some indenting differences, hence the conflict on cherry pick. I've also fixed those differences here so the file should be identical to what is on main.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Continuing in the spirit of opensearch-project#9699, this makes the gradle check comment
less verbose while containing all the same information. The goal is to
reduce visual noise on the PR feed and maybe allow for more comments
before GitHub starts hiding older comments behind the "load more" link.

This is super subjective so happy to hear any opinions if the previous
format is preferred.

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit dcb64d8)
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 55bf620

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git]

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross
Copy link
Member Author

Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #11160 (55bf620) into 2.x (827099e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x   #11160      +/-   ##
============================================
+ Coverage     70.88%   70.89%   +0.01%     
- Complexity    58926    58973      +47     
============================================
  Files          4862     4862              
  Lines        278389   278389              
  Branches      40806    40806              
============================================
+ Hits         197336   197377      +41     
+ Misses        64289    64278      -11     
+ Partials      16764    16734      -30     

see 475 files with indirect coverage changes

@reta reta merged commit 7ff594c into opensearch-project:2.x Nov 11, 2023
43 of 69 checks passed
@andrross andrross deleted the backport/backport-11151-to-2.x branch November 13, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants