Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Fix refresh lag bug on primary term change #10918

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Oct 25, 2023

Description

There is a bug in RemoteStoreRefreshListener class which is occurring on primary term change when a retry is happening. This is more prominent during index creation and failover.

Related Issues

Resolves #10917

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework Storage:Remote labels Oct 25, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94 ashking94 requested a review from VachaShah as a code owner October 25, 2023 12:39
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023

Compatibility status:

Checks if related components are compatible with change 8175cb3

Incompatible components

Incompatible components: [https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions github-actions bot added the v2.12.0 Issues and PRs related to version 2.12.0 label Oct 25, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member

mch2 commented Oct 25, 2023

Gradle Check (Jenkins) Run Completed with:

#7557

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #10918 (8175cb3) into main (44a9f18) will decrease coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 87.50%.

@@             Coverage Diff              @@
##               main   #10918      +/-   ##
============================================
- Coverage     71.22%   71.14%   -0.09%     
+ Complexity    58721    58645      -76     
============================================
  Files          4872     4872              
  Lines        276682   276685       +3     
  Branches      40219    40221       +2     
============================================
- Hits         197070   196846     -224     
- Misses        63163    63408     +245     
+ Partials      16449    16431      -18     
Files Coverage Δ
...search/index/shard/RemoteStoreRefreshListener.java 86.76% <87.50%> (-0.30%) ⬇️

... and 465 files with indirect coverage changes

@mch2 mch2 merged commit b17d4a8 into opensearch-project:main Oct 26, 2023
@mch2 mch2 added the backport 2.x Backport to 2.x branch label Oct 26, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 26, 2023
* [Remote Store] Fix refresh lag bug on primary term change

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add Integ Tests

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit b17d4a8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Oct 26, 2023
…10935)

* [Remote Store] Fix refresh lag bug on primary term change



* Add Integ Tests



* Incorporate PR review feedback



* Empty-Commit



---------


(cherry picked from commit b17d4a8)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…-project#10918)

* [Remote Store] Fix refresh lag bug on primary term change

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Add Integ Tests

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Incorporate PR review feedback

Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working skip-changelog Storage:Durability Issues and PRs related to the durability framework Storage:Remote v2.12.0 Issues and PRs related to version 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Race condition in RemoteStoreRefreshListener that leads to refresh lag increasing
3 participants