Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Make index and global metadata upload timeout dynamic cluster setting #10852

Conversation

rahulkarajgikar
Copy link
Contributor

@rahulkarajgikar rahulkarajgikar commented Oct 23, 2023

Description

Backport PR of #10814

Related Issues

Resolves #10688

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

opensearch-project#10814)

* Make index and global metadata upload wait time dynamic

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
(cherry picked from commit 8f13dee)
@rahulkarajgikar rahulkarajgikar marked this pull request as ready for review October 23, 2023 10:17
@rahulkarajgikar rahulkarajgikar changed the title Make index and global metadata upload timeout dynamic cluster setting… [Backport 2.x] Make index and global metadata upload timeout dynamic cluster setting Oct 23, 2023
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change e7c7339

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteIndexShardTests.classMethod
      1 org.opensearch.index.shard.RemoteIndexShardTests.testSegRepSucceedsOnPreviousCopiedFiles
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #10852 (e7c7339) into 2.x (59e4060) will decrease coverage by 0.12%.
Report is 6 commits behind head on 2.x.
The diff coverage is 65.00%.

@@             Coverage Diff              @@
##                2.x   #10852      +/-   ##
============================================
- Coverage     71.03%   70.91%   -0.12%     
+ Complexity    58771    58687      -84     
============================================
  Files          4843     4844       +1     
  Lines        277307   277320      +13     
  Branches      40677    40677              
============================================
- Hits         196979   196656     -323     
- Misses        63564    63929     +365     
+ Partials      16764    16735      -29     
Files Coverage Δ
...on/admin/cluster/node/stats/NodesStatsRequest.java 70.19% <100.00%> (+0.28%) ⬆️
.../cluster/node/stats/TransportNodesStatsAction.java 100.00% <100.00%> (ø)
...min/cluster/stats/TransportClusterStatsAction.java 70.83% <ø> (ø)
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
.../java/org/opensearch/gateway/GatewayMetaState.java 69.25% <100.00%> (-0.19%) ⬇️
...earch/index/SegmentReplicationPressureService.java 76.69% <100.00%> (ø)
...ensearch/index/SegmentReplicationStatsTracker.java 95.83% <100.00%> (+0.37%) ⬆️
server/src/main/java/org/opensearch/node/Node.java 85.22% <100.00%> (+0.03%) ⬆️
...src/main/java/org/opensearch/node/NodeService.java 71.91% <50.00%> (-0.51%) ⬇️
...arch/gateway/remote/RemoteClusterStateService.java 70.43% <89.47%> (+0.57%) ⬆️
... and 3 more

... and 448 files with indirect coverage changes

@shwetathareja shwetathareja merged commit 9cf9e8a into opensearch-project:2.x Oct 23, 2023
77 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants