Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include sources and javadoc artifacts while publishing to a Maven repository #1049

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Conversation

adnapibar
Copy link
Contributor

Description

This change fixes the issue where running publish commands, the sources and javadoc artifacts were not built and included with the publications.

Issues Resolved

#1028

Check List

  • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda adnapibar@gmail.com

…ository.

This change fixes the issue where running publish commands the sources and javadoc artifacts were not built and included with each publication.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar requested a review from mch2 August 4, 2021 23:35
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 7c756ad

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 7c756ad

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 7c756ad

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 7c756ad
Log 370

Reports 370

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 5df72da

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Wrapper Validation success 5df72da

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Precommit success 5df72da

Copy link
Member

@mch2 mch2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adnapibar
Copy link
Contributor Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5df72da
Log 373

Reports 373

@adnapibar adnapibar merged commit 7469bf6 into opensearch-project:main Aug 5, 2021
adnapibar added a commit that referenced this pull request Aug 24, 2021
…ository (#1049) (#1139)

This change fixes the issue where the sources and javadoc artifacts were not built and included with the publish.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
adnapibar added a commit that referenced this pull request Aug 27, 2021
…ository (#1049) (#1162)

This change fixes the issue where the sources and javadoc artifacts were not built and included with the publish.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
@adnapibar adnapibar deleted the publish-sources branch December 26, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants