Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Updating the separator for RemoteStoreLockManager since underscore is allowed in base64UUID url charset #10428

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 66aef13 from #10379.

… allowed in base64UUID url charset (#10379)

* Refactor Remote Store Metadata Lock Manager Utils

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

* Address PR Comments

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

* Address PR Comments

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

* Update Changelog entry

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

* Update Changelog entry

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

* Unmute testDeleteShallowCopySnapshot test

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>

---------

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Co-authored-by: Harish Bhakuni <hbhakuni@amazon.com>
(cherry picked from commit 66aef13)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Compatibility status:

Checks if related components are compatible with change 9d013fd

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #10428 (9d013fd) into 2.x (fc7dc20) will increase coverage by 0.21%.
Report is 10 commits behind head on 2.x.
The diff coverage is 79.38%.

@@             Coverage Diff              @@
##                2.x   #10428      +/-   ##
============================================
+ Coverage     70.75%   70.96%   +0.21%     
- Complexity    58397    58556     +159     
============================================
  Files          4816     4829      +13     
  Lines        276031   276342     +311     
  Branches      40565    40576      +11     
============================================
+ Hits         195306   196110     +804     
+ Misses        64105    63536     -569     
- Partials      16620    16696      +76     
Files Coverage Δ
...arch/telemetry/metrics/DefaultMetricsRegistry.java 100.00% <100.00%> (ø)
...ch/telemetry/metrics/noop/NoopMetricsRegistry.java 100.00% <100.00%> (ø)
...va/org/opensearch/telemetry/metrics/tags/Tags.java 100.00% <100.00%> (ø)
...org/opensearch/repositories/url/URLRepository.java 72.00% <100.00%> (ø)
...g/opensearch/transport/netty4/Netty4Transport.java 73.65% <100.00%> (ø)
...opensearch/repositories/azure/AzureRepository.java 68.88% <100.00%> (-1.33%) ⬇️
...g/opensearch/repositories/hdfs/HdfsRepository.java 61.90% <100.00%> (ø)
...java/org/opensearch/repositories/s3/S3Service.java 76.04% <100.00%> (ø)
.../org/opensearch/telemetry/OTelTelemetryPlugin.java 100.00% <100.00%> (ø)
...rg/opensearch/telemetry/OTelTelemetrySettings.java 100.00% <100.00%> (ø)
... and 41 more

... and 487 files with indirect coverage changes

@sohami sohami merged commit ae64725 into 2.x Oct 5, 2023
@github-actions github-actions bot deleted the backport/backport-10379-to-2.x branch October 6, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant