Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment Replication - Fix ShardLockObtained error during corruption cases #10370

Merged
merged 12 commits into from
Oct 5, 2023
Merged

Segment Replication - Fix ShardLockObtained error during corruption cases #10370

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e69fb21
Segment Replication - Fix ShardLockObtained error during corruption c…
mch2 Oct 4, 2023
2d9262e
Remove exra logs
mch2 Oct 4, 2023
95fa8c7
Remove flaky assertion on store refcount
mch2 Oct 4, 2023
31dc12b
Remove flaky test.
mch2 Oct 5, 2023
645476a
PR Feedback.
mch2 Oct 5, 2023
9ee4c8b
Fix unit test.
mch2 Oct 5, 2023
6a16935
Fix test failure testSegRepSucceedsOnPreviousCopiedFiles.
mch2 Oct 5, 2023
4a7e8c8
spotless
mch2 Oct 5, 2023
8eca892
Revert flaky IT
mch2 Oct 5, 2023
f88dc86
Fix flakiness failure by expecting RTE when check index fails.
mch2 Oct 5, 2023
9dfc85d
reintroduce ITs and use recoveries API instead of waiting on shard st…
mch2 Oct 5, 2023
2b80149
Fix edge case where flush failures would not get reported as corruption.
mch2 Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spotless 
Signed-off-by: Marc Handalian <handalm@amazon.com>
  • Loading branch information
@mch2
mch2 committed Oct 5, 2023
commit 4a7e8c87b3cbf9641f807a7f203653cdcbad19ad
10 changes: 4 additions & 6 deletions server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,12 +525,10 @@ public void onResponse(Void o) {
@Override
public void onFailure(Exception e) {
logger.debug("Replication failed {}", target.description());
if (isStoreCorrupt(target)
|| e instanceof CorruptIndexException
|| e instanceof OpenSearchCorruptionException) {
onGoingReplications.fail(replicationId, new ReplicationFailedException("Store corruption during replication", e), true);
return;
}
if (isStoreCorrupt(target) || e instanceof CorruptIndexException || e instanceof OpenSearchCorruptionException) {
onGoingReplications.fail(replicationId, new ReplicationFailedException("Store corruption during replication", e), true);
return;
}
onGoingReplications.fail(replicationId, new ReplicationFailedException("Segment Replication failed", e), false);
}
});
Expand Down