Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Feature] Visitor design pattern in QueryBuilder #10167

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[Backport 2.x] [Feature] Visitor design pattern in QueryBuilder #10167

merged 2 commits into from
Sep 21, 2023

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Sep 21, 2023

Description

Backport 10110 to 2.x

Related Issues

Resolves #[Issue number to be closed when this PR is merged]
9986

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <varunudr@amazon.com>
@vibrantvarun vibrantvarun self-assigned this Sep 21, 2023
@kotwanikunal kotwanikunal changed the title backport/backport-10110-to-2.x [Backport 2.x] [Feature] Visitor design pattern in QueryBuilder Sep 21, 2023
@Poojita-Raj
Copy link
Contributor

Hey @vibrantvarun, rebase for conflicts?

Signed-off-by: Varun Jain <varunudr@amazon.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

Compatibility status:

Checks if related components are compatible with change cf10d30

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #10167 (cf10d30) into 2.x (ad9355f) will increase coverage by 0.09%.
Report is 3 commits behind head on 2.x.
The diff coverage is 91.39%.

@@             Coverage Diff              @@
##                2.x   #10167      +/-   ##
============================================
+ Coverage     70.83%   70.93%   +0.09%     
- Complexity    58250    58353     +103     
============================================
  Files          4811     4812       +1     
  Lines        275316   275404      +88     
  Branches      40464    40485      +21     
============================================
+ Hits         195033   195360     +327     
+ Misses        63576    63349     -227     
+ Partials      16707    16695      -12     
Files Changed Coverage Δ
...ava/org/opensearch/index/mapper/MapperService.java 74.79% <ø> (ø)
...g/opensearch/index/query/BoostingQueryBuilder.java 87.25% <66.66%> (-1.29%) ⬇️
...rg/opensearch/index/query/SpanNotQueryBuilder.java 90.43% <66.66%> (-1.31%) ⬇️
...nsearch/index/query/SpanMultiTermQueryBuilder.java 82.02% <75.00%> (-0.34%) ⬇️
...org/opensearch/index/query/DisMaxQueryBuilder.java 88.00% <85.71%> (-0.18%) ⬇️
...g/opensearch/index/query/SpanNearQueryBuilder.java 80.97% <85.71%> (-1.51%) ⬇️
...org/opensearch/index/query/SpanOrQueryBuilder.java 89.33% <85.71%> (-0.38%) ⬇️
...search/telemetry/tracing/OTelResourceProvider.java 100.00% <100.00%> (ø)
...etry/tracing/exporter/OTelSpanExporterFactory.java 77.77% <100.00%> (+6.34%) ⬆️
...a/org/opensearch/index/query/BoolQueryBuilder.java 95.53% <100.00%> (+0.62%) ⬆️
... and 7 more

... and 502 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testShallowCloneNameAvailability

@owaiskazi19 owaiskazi19 merged commit 9d7644a into opensearch-project:2.x Sep 21, 2023
@vibrantvarun vibrantvarun deleted the backport/backport-10110-to-2.x branch September 21, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants