Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken backward compatibility from 2.7 for IndexSorted field indices #10045

Merged
merged 13 commits into from
Sep 15, 2023
Merged

Fix broken backward compatibility from 2.7 for IndexSorted field indices #10045

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3bb0cc0
Fix broken backward comparibility from 2.7 for IndexSorted field indices
gashutos Sep 14, 2023
f3ff4c1
Adding CHANGELOG
gashutos Sep 14, 2023
7d4359a
Update server/src/main/java/org/opensearch/index/IndexSettings.java
gashutos Sep 14, 2023
97d650f
Removing unwanted logs
gashutos Sep 14, 2023
9e9ae13
Removing unwanted logs
gashutos Sep 14, 2023
51ed422
Adding index sort as part of mixed cluster to test this scenario
gashutos Sep 14, 2023
b037213
Removing optimization disable logic
gashutos Sep 14, 2023
a7e09c6
Correcting some comments & version check to before( V_2_7_0) instead …
gashutos Sep 15, 2023
7f81045
Resolving spotless check error
gashutos Sep 15, 2023
2575a45
Fixing broken UT - last minute checkin without copile
gashutos Sep 15, 2023
f61aba6
Improving code coverage to make codcov happy
gashutos Sep 15, 2023
61d355e
Correcting typos and adding more tests
gashutos Sep 15, 2023
af7e9e9
Removing unwanted imports
gashutos Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing unwanted logs 
Signed-off-by: gashutos <gashutos@amazon.com>
  • Loading branch information
@gashutos
gashutos committed Sep 14, 2023
commit 97d650fa67541122620534eb8488c7baec1a374c
1 change: 1 addition & 0 deletions server/src/main/java/org/opensearch/index/IndexSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import org.apache.logging.log4j.Logger;
import org.apache.lucene.index.MergePolicy;
import org.apache.lucene.sandbox.index.MergeOnFlushMergePolicy;
import org.opensearch.LegacyESVersion;
import org.opensearch.Version;
import org.opensearch.cluster.metadata.IndexMetadata;
import org.opensearch.common.annotation.PublicApi;
Expand Down
1 change: 0 additions & 1 deletion server/src/main/java/org/opensearch/search/sort/FieldSortBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ public SortFieldAndFormat build(QueryShardContext context) throws IOException {
}
IndexNumericFieldData numericFieldData = (IndexNumericFieldData) fieldData;
NumericType resolvedType = resolveNumericType(numericType);
System.out.println("CHETAN LOGS : " + resolvedType);
field = numericFieldData.sortField(resolvedType, missing, localSortMode(), nested, reverse);
isNanosecond = resolvedType == NumericType.DATE_NANOSECONDS;
} else {
Expand Down