Skip to content

Mechanism to ensure newly added tests are not flaky #9462

Open
@dreamer-89

Description

Today, there exists multiple flaky tests which often results in unstable builds or gradle check failure. The later is more frustrating as it blocks the PR and needs explicit retry in the hope of passing gradle check. In order to ensure, we are not adding more flaky tests with new development, we can employ below two mechanisms to gate flaky tests from merge.

1. Guide

  • Update pull_request_template.md to add/update line item to run newly added tests locally. Run integration tests at least 100 times & unit test 1000 times without failure.
  • Update developer guide with recommendation to run tests locally before submitting PR.

2. Github workflow

  • Add new github workflow which runs newly added tests in repetition. This supplements step 1 above.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    BuildBuild Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement.Build Libraries & InterfacesdiscussIssues intended to help drive brainstorming and decision makingenhancementEnhancement or improvement to existing feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions