Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support using sandbox functionality in official releases #3677

Open
mattweber opened this issue Jun 23, 2022 · 7 comments
Open

Add support using sandbox functionality in official releases #3677

mattweber opened this issue Jun 23, 2022 · 7 comments
Labels
Build Libraries & Interfaces discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request feature New feature or request

Comments

@mattweber
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not being able to use sandbox features unless using a snapshot. Snapshots are not published for all release formats, ie. docker images so it is not easy to experiment/test/play with sandbox features.

Describe the solution you'd like
I would like sandbox features built and shipped with official releases and then have some sort of startup option to enable their use. Enabling a sandbox feature would imply the user opting into experimental features and understands it is unsupported.

Describe alternatives you've considered
Building from source.

Additional context
I am excited to try concurrent search plugin

@mattweber mattweber added enhancement Enhancement or improvement to existing feature or request untriaged labels Jun 23, 2022
@saratvemulapalli saratvemulapalli added discuss Issues intended to help drive brainstorming and decision making Build Libraries & Interfaces and removed untriaged labels Jun 28, 2022
@minalsha minalsha added the feature New feature or request label Jun 28, 2022
@andrross
Copy link
Member

andrross commented Sep 22, 2022

@nknize What do you think about this proposal? Since a user has to explicitly install a plugin, and the fact they are located in a "sandbox" directory, this seems like a reasonable process akin to enabling a feature flag and would greatly reduce the friction for users experimenting with a sandbox plugin.

then have some sort of startup option to enable their use

@mattweber The "option" here is just to install the plugin since sandbox features are inherently plugins. Does that make sense to you or were you thinking about something else?

/cc @reta

@reta
Copy link
Collaborator

reta commented Sep 23, 2022

+1 to @andrross suggestion, alrenatively we could publish sandbox plugin ZIPs into well known repository so people could use it (and make opensearch-plugin tool aware of that).

@peternied
Copy link
Member

+1

@saratvemulapalli
Copy link
Member

We could definitely publish the zips just like native plugins today which should help install these plugins.
Also a question pops in my mind, how do we want to deal with sandbox/modules?

@andrross
Copy link
Member

Also a question pops in my mind, how do we want to deal with sandbox/modules?

@saratvemulapalli Should we just remove it? The concept of the sandbox seems inherently optional to me. I could imagine a feature being promoted from sandbox/plugins to modules, but during its sandbox phase is should probably be an optional plugin.

@reta
Copy link
Collaborator

reta commented Feb 15, 2023

Could we combine it with a feature flag? The sandbox/modules could be bundled (similarly to regular modules) but never picked up by default (if it is feasible to do).

@wbeckler
Copy link

Without a way for people to try out the sandboxed modules, there is less chance that we can learn from the experimental usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Libraries & Interfaces discuss Issues intended to help drive brainstorming and decision making enhancement Enhancement or improvement to existing feature or request feature New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants